Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

A right-to-left document renders against the left edge, and `start`/`end` alignment resolves to the wrong side

Ouverte
  • Quelque chose ne va pas ?
#653 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Calme
Stack technique
cpp
Domaine
web-dev

Piste de recherche

Start in the odrcore submodule: HtmlWriter::write_begin (html_writer.cpp:134) is where dir/lang would go on <html>. read_text_align (odf_style.cpp:108) maps start/end to left/right — first decide with the maintainer whether to keep start/end in TextAlign and emit text-align:start/end, or resolve at translation time. Then parse style:writing-mode into ParagraphStyle (style.hpp:166) and emit it in translate_paragraph_style (document_style.cpp:237). Done when an Arabic document renders flush right and mixed-direction paragraphs are ordered correctly.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

A user asked for right-to-left support in a Play Store review of 4.18.0, in Arabic, rating the app 5 ★ anyway. #468 is the same request from a support email, and #108 asked for it in 2019 and was closed without it. This is what is actually missing, because it is three separate things and only one of them is a feature.

The fix is in odrcore in all three cases; nothing on the Android side is involved. odrcore has #326 for the spreadsheet half of this.

The view has no base direction

HtmlWriter::write_begin writes a bare <html> (html_writer.cpp:134). No dir, no lang, anywhere in the output. So the WebView takes the default base direction, which is left-to-right.

That is not "Arabic does not render". The Unicode bidi algorithm still orders an Arabic run right-to-left inside a line, so a paragraph of pure Arabic reads correctly. What breaks is everything that depends on the paragraph's own direction: the sentence lands against the left edge, trailing punctuation goes to the wrong end, and a paragraph mixing Arabic with Latin words or digits is ordered by the wrong base.

style:writing-mode is never read

ODF states paragraph and page direction as style:writing-mode, rl-tb being right-to-left. Nothing parses it — there is no writing_mode anywhere in internal/odf/, and ParagraphStyle (style.hpp:166) has no field to put it in. The only writing-mode the translator ever emits is vertical-lr for a rotated table cell (document_style.cpp:415), which is unrelated.

So even with a base direction on <html>, a right-to-left paragraph inside an otherwise left-to-right document would still come out wrong, and vice versa.

start and end alignment resolve to the wrong edge

This one is a bug rather than a gap, and it is the visible one.

read_text_align (odf_style.cpp:108) maps fo:text-align values start → TextAlign::left and end → TextAlign::right, unconditionally. But start and end are relative to the writing direction: in a right-to-left paragraph start is the right edge. translate_paragraph_style (document_style.cpp:237) then writes that out as a literal text-align:left.

start is what writers emit for ordinary body text rather than left, so this hits the common case: a right-to-left document whose paragraphs are simply default-aligned renders flush left, and it stays flush left even if the base direction is fixed, because the wrong edge was baked in at parse time.

What we could do

TextAlign has the shape of the problem in it — left/right/center/justify, with no start/end. Two ways out:

  1. Keep start/end all the way to the CSS. Add them to TextAlign and emit text-align:start / text-align:end, which browsers resolve against the element's direction. Then parse style:writing-mode into a direction on ParagraphStyle, emit it as direction:rtl, and the alignment follows for free. The public enum gains two values, so this is a breaking change for the bindings.
  2. Resolve at translation time, once direction is known, and leave the enum alone. Cheaper, and it puts the writing direction into the style model either way — so it is most of the same work with a worse result.

Either way <html dir> (or a direction on the document root element) still has to be set from the document's page style, or a document that states nothing per paragraph gets no direction at all.

Worth deciding whether the same pass carries lang, which is in the ODF too and which nothing currently emits — it is what a screen reader and hyphenation need, and it is the same attribute pair.

Langage dominant
Kotlin
Étoiles
473
Forks
44
Merge moyen
4 h 7 min
PR mergées (30 j)
54

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de opendocument-app/OpenDocument.droid

Toutes les issues de opendocument-app/OpenDocument.droid

Issues similaires

Plus d'issues Kotlin

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.