[Bug]: Recipients can no longer see or copy existing public link shares (regression from #65258)
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 48/100
Piste de recherche
Start with ShareAPIController::formatShare() and the token visibility condition changed in PR #65258; compare it with canEditShare() and the existing permission check. Reproduce with the OCS shares endpoint and the two-user steps in the issue. Done means user B can see and copy the existing public link when the permission check allows it, without exposing links beyond those permissions.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
⚠️ This issue respects the following points: ⚠️
- This is not a troubleshooting question, general support matter, or webserver/proxy problem, but likely a bug (if unsure, ask the Community Help Forum).
- This issue is not already reported on Github OR solved at the Community Help Forum (I've searched!).
- I'm using a maintained major version of Nextcloud Server and tested against the latest patch level. (Supported major versions and current patch levels).
- I agree to follow Nextcloud's Code of Conduct.
- I've tried my best to provide clear reproduction steps that someone unfamiliar with this bug could use to reproduce it.
Bug description
Description
A user who received a share with full permissions (including reshare) can still see in the sharing sidebar that a public link exists on the folder, but the "Copy link" button is no longer displayed.
The OCS API returns the link share with token: null and url: null to anyone who is not the file owner or the share initiator.
Impact
This breaks a common workflow: people working in a shared folder used to copy the existing public link. They now have to create additional links, which multiplies the links to manage.
Root cause
PR #65258 ("fix: use correct node when formatting share token", backported in #65259–#65264) changed the token condition in ShareAPIController::formatShare():
- $token = $userHasEnoughPermissions ? $share->getToken() : null;
+ $token = $userHasEnoughPermissions && $this->canEditShare($share) ? $share->getToken() : null;
The PR description only mentions replacing a possibly null $recipientNode with $node. The added canEditShare() check is not mentioned, yet it changes behaviour significantly:
canEditShare()only returnstruefor the file owner, the share initiator, or ownerless mounts (team folders).- The existing permission check, which redacts the token when the link grants more permissions than the current user has, already covers the risk of a recipient escalating their permissions through a link.
Steps to reproduce
- User A creates a folder and a read-only public link share on it.
- User A shares the same folder with user B with all permissions (including reshare).
- User B opens the folder's sharing sidebar.
- The existing public link is listed, but there is no "Copy link" button.
The API call confirms the redaction:
GET /ocs/v2.php/apps/files_sharing/api/v1/shares?path=/folder&reshares=true
returns the link share with token: null and url: null.
Expected behavior
- If this restriction is intentional: could it be documented (changelog, admin manual) and ideally made configurable?
- Otherwise: could the
canEditShare()condition be removed from the token visibility check, keeping only the permission comparison?
Nextcloud Server version
35
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.5
Web server
Apache (supported)
Database engine version
None
Is this bug present after an update or on a fresh install?
Updated from a MINOR version (ex. 32.0.1 to 32.0.2)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
List of activated Apps
Nextcloud Signing status
No errors have been found
Nextcloud Logs
Additional info
No response
- Langage dominant
- PHP
- Étoiles
- 37.5k
- Forks
- 5.4k
- Merge moyen
- 1 j 13 h
- PR mergées (30 j)
- 639
Préparer son environnement
Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de nextcloud/server
-
35-feedback
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
-
0. Needs triage 35-feedback bug
Difficulté 2/5 1-3 heures Accessibilité débutants 66/100
Les mainteneurs répondent en général sous 1 jour
-
workflowengine: File entity reuses the node of the first "Tag assigned" event for all later events in the same processPeut-être pris @lazerg l’a pris il y a 2 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 62/100
Les mainteneurs répondent en général sous 1 jour
-
Contacts import aborts with TypeError when vCards have no UID (TextImporter structure)Peut-être pris @SebastianKrupinski l’a pris il y a 6 jours. Ouvertebug
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
nextcloud/server#66486 · 2 commentaires · 2 réactions · 1 personne assignée ·
Les mainteneurs répondent en général sous 1 jour
-
Unified search: screen reader hears "No matching results" on mobile even when there are resultsPeut-être pris @lazerg l’a pris il y a 10 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de nextcloud/server
Issues similaires
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Ouvertesync-en
Difficulté 2/5 1-3 heures Accessibilité débutants 66/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 79/100
Automattic/blocks-engine#6318 ·
Les mainteneurs répondent en général sous 1 jour
-
Update: Laravel Cheat Sheet - middleware examples for the bootstrap/app.php layout (small update)Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
OWASP/CheatSheetSeries#2990 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 1/5 1-3 heures Accessibilité débutants 82/100
Les mainteneurs répondent en général sous 1 jour