memory: create_entities, create_relations and add_observations could declare idempotentHint: true

Fermée Adaptée aux débutants
  • Quelque chose ne va pas ?
#5,153 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@syedmustafan y travaille déjà.

Depuis le 17/10/2026.

  • #1 par @syedmustafan — ouverte

Évaluation

Difficulté
1/5
Temps estimé
Moins d'une heure
Accessibilité débutants
78/100
Type d'issue
Refactorisation
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript, nodejs, typescript
Domaine
api

Piste de recherche

Les trois outils sont déclarés dans src/memory/index.ts sur v2/main, autour des lignes 797, 842 et 888, où idempotentHint vaut actuellement false. Vérifie que les handlers createEntities, createRelations et addObservations ignorent déjà le travail en double, puis passe les trois hints à true, comme les outils de suppression. C'est terminé lorsque les déclarations sont mises à jour et que la sortie de listage des outils du serveur mémoire affiche true pour ces trois outils.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement server-memory v2
Which server?

memory (@modelcontextprotocol/server-memory)

Protocol era

Both, or not era-specific

MCP client

mcp-groundtruth's own JSON-RPC stdio client (test harness, protocolVersion 2025-11-25)

The problem

create_entities, create_relations and add_observations declare idempotentHint: false, although a repeated identical call has no additional effect. Clients that respect the hint may therefore decline to auto-retry them, for example after a timeout. The three delete tools already declare idempotentHint: true for the same reason: a repeat has nothing left to do.

All three already skip work that has been done (src/memory/index.ts at bbb701e, the commit tested):

  • createEntities skips names that already exist or repeat earlier in the batch (L517–L532).
  • createRelations skips relations that already exist or repeat in the batch (L534–L564).
  • addObservations skips contents the entity already has (L566–L585).

v2/main at 38569bd still declares false (L797, L842, L888), and the three methods are unchanged between the two commits.

Solution you have in mind (optional)

Set idempotentHint: true on these three tools. Their behaviour doesn't change; only the declared hint does, matching the delete tools.

Which MCP feature does it demonstrate? (optional)

Tool annotations (idempotentHint). Reference servers are widely copied, so their hints are often reused as a model for what each one means.
https://modelcontextprotocol.io/specification/2025-11-25/server/tools

Alternatives or workarounds you have tried

Leaving it as is is safe: clients just retry less than they could. A client could hardcode a per-tool override, but that defeats the purpose of declaring hints on the server.

Already built it locally?

No local change, so no prompt to share. How this was verified:

I tested the three tools against a seeded graph with mcp-groundtruth, a conformance harness I maintain, sandboxed, on Node 24. There were 12 argument sets: existing names with a different type or new observations, duplicates within a batch, a missing relation endpoint, a partly invalid batch, and mixes of new and existing items. In every set a second identical call left the stored graph unchanged, and calls that returned errors wrote nothing. Reports and review.

Reproduce, with Node 24 first on PATH:

git clone https://github.com/shreyasbhakta/mcp-groundtruth && cd mcp-groundtruth
git checkout 9ba8f289e6f11aa1d334c0af57b803548d3883a1
uv run mcpgt prepare memory
uv run mcpgt run memory --audit --observe-concurrent --tool create_entities --tool create_relations --tool add_observations

Limits:

  • Only repeated identical arguments were tested; that is what the hint covers.
  • The concurrent evidence is weak. In 180 two-process attempts the requests overlapped on the wire and none diverged, but the lock file serializes writes.
  • One seed graph and 12 hand-chosen argument sets, on macOS only.

Environment: server built from source at bbb701e and run over stdio; client sends protocolVersion: "2025-11-25" and the server answers with the same; macOS, Node 24.21.0.

Before you submit
  • I searched existing issues and this is not a duplicate.
  • This is a request for this repository or one of its servers, not a new server, the MCP specification or an SDK.
Langage dominant
TypeScript
Étoiles
91.7k
Forks
11.9k
Merge moyen
3 h 48 min
PR mergées (30 j)
180

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de modelcontextprotocol/servers

Toutes les issues de modelcontextprotocol/servers

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.