Support C# union return values in tools, prompts, and resources

Ouverte
#2,015 1 commentaire 1 réaction 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
csharp

Piste de recherche

Read the result switches in AIFunctionMcpServerTool.cs, AIFunctionMcpServerPrompt.cs, and AIFunctionMcpServerResource.cs, then trace how their current cases handle direct return values. Check how compiler generated unions expose their active case and account for older target frameworks and Native AOT. Done means union cases behave like their directly returned values across tools, prompts, and resources while preserving output schemas and older protocol compatibility.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

P3

Description

When a tool, prompt, or resource method returns a C# union, its active case is not handled like the same value returned directly. The SDK's result conversion sees the boxed union rather than the active value.

Reproduction

Run this with the .NET 11 SDK, targeting net11.0 with LangVersion set to preview:

using System;
using System.IO;
using ModelContextProtocol.Protocol;
using ModelContextProtocol.Server;

await using var server = McpServer.Create(
    new StreamServerTransport(Stream.Null, Stream.Null),
    new McpServerOptions());

var tool = McpServerTool.Create(
    () => (TextOrImage)"hello",
    new() { Name = "example" });

var request = new RequestContext<CallToolRequestParams>(
    server,
    new JsonRpcRequest { Method = "tools/call" },
    new CallToolRequestParams { Name = "example" });

var result = await tool.InvokeAsync(request);
Console.WriteLine(((TextContentBlock)result.Content[0]).Text);

public union TextOrImage(string, ImageContentBlock);

The text contains "hello", including the quote characters. Returning "hello" directly produces hello without those characters. An ImageContentBlock case is similarly serialized into a text block instead of being returned as image content. A CallToolResult case is serialized into text rather than passed through, so properties such as IsError are not propagated as result properties.

Prompts and resources have the same underlying issue, but throw instead of falling back to JSON serialization. For example, a prompt returning the string case of union TextOrPrompt(string, PromptMessage) throws InvalidOperationException: Unknown result type 'TextOrPrompt' returned from prompt function. A resource returning the string case of union TextOrResource(string, ResourceContents) throws InvalidOperationException: Unsupported result type 'TextOrResource' returned from resource function.

Expected behavior

Handle a union's active case as the corresponding directly returned value for tools, prompts, and resources. Preserve the existing handling of ordinary return values, structured content and output schemas, including compatibility with older protocol versions.

Investigation

The result switches in AIFunctionMcpServerTool, AIFunctionMcpServerPrompt, and AIFunctionMcpServerResource match the boxed union rather than its active case. Compiler-generated unions implement System.Runtime.CompilerServices.IUnion on .NET 11; the SDK also targets older frameworks, so compatibility and Native AOT need consideration.

Reproduced against the SDK at commit 64cfd66b147553d8cf953f9e2a374aae96014968, using its net10.0 Core build in a .NET 11 application.

[!NOTE]
This issue was drafted with GitHub Copilot.

Langage dominant
C#
Étoiles
4.6k
Forks
849
Merge moyen
1 j 16 h
PR mergées (30 j)
24

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de modelcontextprotocol/csharp-sdk

Toutes les issues de modelcontextprotocol/csharp-sdk

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.