Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Android: `HttpClient$FutureShim` JNI references are never released after requests complete, leading to a reference-table overflow abort

Ouverte
  • Quelque chose ne va pas ?
#1,551 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
1-2 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
android, cpp
Domaine
backend, mobile

Piste de recherche

Start in lib/http/HttpClient_Android.cpp and trace SendRequestAsync, dispatchCallback, CallbackForCancel, and CancelAllRequests, checking how JNI local and global references are released on completion and cancellation. Reproduce the reported reference growth with the heap dump steps in the issue, then verify completed, cancelled, and failed requests release their references.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

On Android, completed com.microsoft.applications.events.HttpClient$FutureShim objects (the FutureTask created by createTask) build up as JNI GC roots and are never released. Over a long session this approaches ART's 51,200-entry JNI reference limit and the process aborts with JNI ERROR (app bug): global reference table overflow in HttpClient_Android::SendRequestAsync.

Environment
  • SDK: maesdk 3.10.40.1 (a Teams-specific build based on this repo)
  • Device: Samsung SM-A146B, Android 15 (API 35)
Repro
  1. Run an app that sends 1DS telemetry over the default Android HttpClient.
  2. Force a GC, capture a heap dump, and count HttpClient$FutureShim instances.
  3. Generate normal activity and let queued uploads finish.
  4. Force a GC and capture a second heap dump. Leave the app idle for 3 minutes and capture a third.

Expected: after completion, cancellation or failure, FutureShim instances become collectable and the count falls back toward baseline.

Actual: the count only goes up across heap dumps taken after a forced GC: 2,194 → 2,587 → 2,607.

  • Every inspected instance is already complete: FutureTask.state == 2, and callable, runner and waiters are all null.
  • Representative instances are held directly by ROOT_JNI_LOCAL roots.
  • Crash evidence from the field shows about 50,257 FutureShim references at the time of the reference-table overflow abort.
Suspected cause (lib/http/HttpClient_Android.cpp)
  • SendRequestAsync: result = env->PopLocalFrame(result) hands back a new local reference in the caller's frame, and nothing ever calls DeleteLocalRef on it. These calls run on native threads that are attached and never detached, so local references are never freed automatically. That matches the ROOT_JNI_LOCAL roots we see.
  • The global reference: m_java_request = env->NewGlobalRef(result) is released only in ~HttpRequest(). Any path that removes the request from m_requests without destroying the HttpRequest would keep the global reference alive. Those paths are dispatchCallback → GetAndRemoveRequest, CallbackForCancel and CancelAllRequests.
  • Minor: CallbackForCancel leaks the local reference returned by GetObjectClass.
Suggested fix
  • Call DeleteLocalRef(result) after executeTask and on the cancel path.
  • Release m_java_request with DeleteGlobalRef as soon as the request reaches a final state (success, cancel, retry replacement, or error/early return), rather than relying on the HttpRequest destructor.
  • Optionally wrap request sends in PushLocalFrame/PopLocalFrame on persistently attached threads.
Workaround

None on the app side. The leaked references are owned by the SDK, and an app cannot safely release them.

Langage dominant
C
Étoiles
104
Forks
67
Merge moyen
2 j 12 h
PR mergées (30 j)
8

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de microsoft/cpp_client_telemetry

Toutes les issues de microsoft/cpp_client_telemetry

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.