Font settings widget saves nonexistent font families without validation - apps silently fall back to arbitrary fonts

Ouverte
#222 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
python
Domaine
desktop

Piste de recherche

Start with xapp/SettingsWidgets.py and inspect how FontButton binds Gtk.FontButton.font-name to GSettings; the issue reports that the chooser accepts arbitrary typed family names. Check what family validation is available through GTK, fontconfig, or Pango, and how the widget is reused by settings modules. Done means nonexistent families are refused or clearly flagged instead of being silently saved; the issue gives no test file to run.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Environment

  • Cinnamon 6.6.7 on Gentoo (upstream settings UI: cinnamon-settings -> Font Selection module)
  • python3-xapp 3.0.2 / xapp 3.2.2 (Python widget xapp/SettingsWidgets.py)
  • GTK 3.24.52

Steps to reproduce

  1. Open System Settings -> Font Selection.
  2. On any row (e.g. "Default font"), open the font chooser, type into the Family field a family that is not installed - for example DejaVu Sans Semi-Condensed (DejaVu Sans only ships a "Condensed" variant, not "Semi-Condensed") - and confirm.
  3. The typed string is persisted verbatim into the gsettings key:
    • gsettings get org.cinnamon.desktop.interface font-name -> 'DejaVu Sans Semi-Condensed 11'
    • the same happens for document-font-name, org.nemo.desktop font and titlebar-font.

Observed

  • The stored family cannot be resolved by fontconfig: fc-match "DejaVu Sans Semi-Condensed" returns LiberationSans-Regular.ttf.
  • GTK applications then silently render with a different, unrelated font. Because every app/toolkit resolves the fallback differently, the UI becomes inconsistent - some parts use the intended font, others a fallback, with no error or warning shown anywhere.

Expected

  • The font widget should validate the selected family against fontconfig (e.g. against the GtkFontChooser family list, or fc-list / Pango) and refuse or flag families that cannot be resolved instead of saving them.

Root cause

  • xapp/SettingsWidgets.py -> FontButton binds Gtk.FontButton.font-name directly to the gsettings key (Gio.SettingsBindFlags.DEFAULT) with no validation.
  • GtkFontChooser's family entry also accepts arbitrary typed family names, so any typo or non-existent variant (e.g. a width such as Semi-Condensed that the family does not ship) reaches the settings keys.

Notes

  • The invalid value is spread to all GTK apps at once: csd-xsettings reads org.gnome.desktop.interface font-name and publishes it as the XSettings Gtk/FontName key.
  • The widget is reused by many Mint settings modules, so this silent path is not specific to one app.
  • A repair/warning on startup when a stored font family cannot be resolved would help users who already have such values in dconf.
Langage dominant
C
Étoiles
173
Forks
52
Métriques de merge des PR
Aucune PR mergée en 30 j

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de linuxmint/xapp

Toutes les issues de linuxmint/xapp

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.