Node details endpoint returns nodes outside public channels

Ouverte
#6,421 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
1/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
django, python
Domaine
api, backend, security

Piste de recherche

Read get_node_details and get_channel_details in contentcuration/contentcuration/views/nodes.py, then inspect the ContentNode.filter_view_queryset approach referenced in #6398. Add regression tests for each acceptance criterion, including anonymous and logged-in access, and check that out-of-scope and nonexistent ids return 404 while public nodes retain their current details. The issue explicitly says it is not open for contribution.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

DEV: backend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

/api/get_node_details/<node_id> needs no login, and refuses a node only when it belongs to an existing channel that isn't public. Nodes in a user's clipboard, orphaned nodes and nodes in deleted public channels all return their full details. A node id that doesn't exist raises DoesNotExist and returns 500 (#5784). The sibling get_channel_details looks channels up through Channel.filter_view_queryset.

Complexity: Low
Target branch: hotfixes

Context
  • get_node_details uses ContentNode.objects.get and checks only channel and not channel.public. get_channel_details uses get_object_or_404 on the view queryset.
  • Reproduced, anonymously: 200 with full details for a node in a user's clipboard tree, for an orphaned node, and for a node in a deleted public channel. get_channel_details returns 404 for that deleted channel.
The Change
  • get_node_details should look the node up through ContentNode.filter_view_queryset, following the strategy in #6398, and return 404 for anything outside it, including ids that don't exist.
Acceptance Criteria
General
  • Each reproduced case in Context returns 404.
  • A nonexistent node id returns 404.
  • Nodes in public channels return the same details as before.
  • A logged-in user gets details for nodes in non-public channels they can view, as get_channel_details already allows for those channels.
Testing
  • Regression tests cover each criterion.

AI usage

I chose which audit findings belong in #6398 and set the access pattern. Claude Code found and reproduced this gap and drafted this issue.

Langage dominant
Python
Étoiles
212
Forks
321
Merge moyen
1 j 7 h
PR mergées (30 j)
14

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de learningequality/studio

Toutes les issues de learningequality/studio

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.