Public v2 endpoints answer 304 before the view runs and cache error responses

Ouverte
#6,408 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
38/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
django, python
Domaine
api, backend, testing

Piste de recherche

Read contentcuration/kolibri_public/views.py around metadata_cache and get_last_modified, then inspect the tests for the contentnode and contentnode_tree endpoints. Add coverage for conditional requests, error response cache headers, and unchanged caching on successful responses; done means all listed acceptance criteria pass.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

DEV: backend

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

metadata_cache wraps every public v2 endpoint in Django's last_modified, keyed on the newest ChannelMetadata.last_updated across all channels. Django answers a request whose If-Modified-Since is later than that with 304 before the view runs, so a request for a missing node, or with invalid parameters, gets 304 instead of 404 or 400. The decorator also marks error responses public and cacheable for 5 minutes, so a CDN serves them to everyone.

Complexity: Low
Target branch: hotfixes

Context
  • metadata_cache and get_last_modified apply last_modified, patch_response_headers and patch_cache_control(public=True) to every response.
  • Reproduced: GET /api/public/v2/contentnode/<nonexistent id>/ with an If-Modified-Since later than the newest channel update returns 304. A 404 or 400 response carries Cache-Control: max-age=300, public, stale-while-revalidate=100.
The Change
  • A conditional request should get 304 only when the view would otherwise return 200.
  • Error responses should not be marked public or cacheable.
Acceptance Criteria
General
  • A request for a missing node or with invalid parameters returns its 404 or 400 whatever its If-Modified-Since.
  • 4xx and 5xx responses from public v2 endpoints carry no public Cache-Control or max-age.
  • 200 responses keep their current caching headers, and conditional requests for them still get 304.
Testing
  • Tests cover each criterion on the contentnode and contentnode_tree endpoints.

AI usage

I scoped the audit. Claude Code found and reproduced these failures and drafted this issue.

Langage dominant
Python
Étoiles
212
Forks
321
Merge moyen
1 j 7 h
PR mergées (30 j)
14

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de learningequality/studio

Toutes les issues de learningequality/studio

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.