feat: support ion-infinite-scroll in a `flex-direction: column-reverse` scroll element

Ouverte
#31,602 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
57/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
frontend

Piste de recherche

Start with core/src/components/infinite-scroll/infinite-scroll.tsx, especially the distance calculation at lines 121–129 and the scrollTop writes in connectedCallback and complete(). Reproduce the report with a column-reverse scroll element and check both position values against the stated threshold behavior. Done means the event fires once within the threshold at the trigger in either direction, and the initial and completion scroll positions remain in range.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

package: core type: feature request
Ionic Framework Version

v9.x (9.0.7)

Current Behavior

A chat-style page lays the scroll element out bottom-up with ion-content::part(scroll) { display: flex; flex-direction: column-reverse; } so that the newest row sits at the bottom and the scroller starts there. In that layout the browser's scrollTop is 0 at the bottom and goes negative towards the top ([-320, 0] in the reproduction).

ion-infinite-scroll computes its distance as if scrollTop were non-negative (core/src/components/infinite-scroll/infinite-scroll.tsx L121–129):

const distanceFromInfinite =
  this.position === 'bottom'
    ? scrollHeight - infiniteHeight - scrollTop - threshold - height
    : scrollTop - infiniteHeight - threshold;

With the trigger placed at the oldest end of the list (the last DOM child, painted at the top) and threshold="100px":

position what happens
top ionInfinite fires on the very first scroll step, 315 px away from the oldest end, and again on every later step (7 of 7 steps fired)
bottom never fires, including at scrollTop = -320, i.e. with the trigger fully on screen at the oldest end

Scroller in the reproduction: scrollHeight 1164, clientHeight 844, so the whole scrollable range is 320 px.

connectedCallback (L96–101) and complete() (L184–200) also write scrollEl.scrollTop = scrollHeight - clientHeight / scrollHeight - prev for position="top", which are positions outside the [-320, 0] range of a column-reverse scroller.

Expected Behavior

The trigger fires once when the user is within threshold of the trigger element, whichever direction the scroll element grows in.

Steps to Reproduce
  1. <ion-content> with the style above, 60 rows of 48 px, and <ion-infinite-scroll position="top" threshold="100px"> as the last child (so it paints at the top).
  2. Listen to ionInfinite, call complete() in the handler, and set scrollTop to -5, -20, -60, … on the scroll element returned by getScrollElement().
  3. Observe one ionInfinite per step. Switch to position="bottom" and scroll all the way up: no event.
Ionic Info

@ionic/core 9.0.7, Chromium 142 (Playwright headless).

Langage dominant
TypeScript
Étoiles
52.8k
Forks
13.3k
Merge moyen
3 j 1 h
PR mergées (30 j)
86

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de ionic-team/ionic-framework

Toutes les issues de ionic-team/ionic-framework

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.