Research: single-codebase Swift rewrite without Peekaboo or Node
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Accessibilité débutants
- 15/100
Piste de recherche
This issue is research and planning only and is closed as not planned for now; it names no implementation files to change. Read the proposed layout and steps, then assess whether the rewrite should proceed and where it should live. Done means resolving the listed open questions and establishing a go/no-go decision; the issue estimates 2–4 days for the rewrite itself.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Research and planning only. Closed as not planned for now; it may be picked up later.
Question
Should we rewrite desktop-tools as one codebase with no Peekaboo, no patch stack and no Node?
Sizing (as of v0.14.1)
| Layer | Size |
|---|---|
| TypeScript (MCP server, client, protocol, wait, tables, notifications) | 5.7k lines, plus 1.3k of tests and 1.5k of scripts |
Our Swift (native/sources) |
8.4k lines |
| Patch stack on Peekaboo 4.8.0 | 63 patches, 15.3k diff lines, about 7.9k added lines |
| Peekaboo repo | 380k lines |
| Peekaboo modules we link | AutomationKit 94k (41k UI services), Bridge 42k, AXorcist 23k, Foundation 5k |
The 48 MCP tools make about 66 distinct Bridge client calls. Much of Bridge is code we never call: agent execution, browser sessions, certification. An estimated 30–50k lines of Peekaboo are actually used. A purpose-built codebase would likely be 25–40k lines in total. Both figures are estimates; call coverage wasn't traced.
Rust vs Swift: decision is Swift
- Speed: language makes no difference. Time goes to (1) one client process per call (
execFileinsrc/client.ts), which pays for spawn, handshake and socket connect each time, and (2) Accessibility IPC round trips per attribute read. The fixes are a persistent connection and batched AX reads (AXUIElementCopyMultipleAttributeValues), in either language. - Testing and safety: Rust only helps the pure logic: protocol, snapshots, stale-target refusal, approval, the wait/expect engine. That's about a third of the code. The bugs that have hurt us come from live macOS behaviour, which only
live-checkcatches. - macOS surface: AX, CGEvent, CGS spaces, TIS and Security are C APIs and would be easy from Rust. ScreenCaptureKit, Vision and AppKit/SwiftUI are where Rust gets painful. We interface with macOS too deeply for Rust to pay off, so we'd skip it.
- Swift gives one language and one toolchain, native frameworks with no FFI, Swift 6 data-race safety (already on), and a Swift MCP server, so Node goes away too.
Proposed layout (single SwiftPM package)
Sources/
DesktopProtocol/ wire types, the 48 tool schemas, error codes, receipts (pure)
DesktopCore/ snapshots, targets/stale refusal, wait/expect, result bounding,
tables/cells, password-fill rules. Pure; the OS sits behind protocols
DesktopMac/ the only module that touches macOS: AX, CGEvent post-to-pid, CGS spaces,
ScreenCaptureKit, Vision OCR, TIS, Keychain, pasteboard, notifications
DesktopHost/ socket server, caller identity and approval, pause, activity, embed C ABI
DesktopOverlay/ agent cursor and window outline
desktop-tools-mcp/ MCP over stdio, one open connection to the host
DesktopToolsApp/ menu bar shell that links DesktopHost
Tests/ CoreTests (fakes), ContractTests (golden schemas), MacTests (opt-in, live)
- Operations run in the app process, because that's what the macOS grants attach to. The MCP binary only translates, and ships signed inside the app bundle:
claude mcp add desktop -- "/Applications/Desktop Tools.app/Contents/MacOS/desktop-tools-mcp". - Write MCP over stdio ourselves (a few hundred lines) rather than pull in the SDK and its dependencies. Aim for no third-party dependencies; AXorcist (unpatched) could be a temporary dependency while bootstrapping.
- A menu bar shell built on GPUI would have to live outside this repo because of its dependency stack.
Steps
- Baseline bench of today's build (below).
- Freeze the contract. Golden tool schemas, error codes and result shapes. Port the TS logic tests to Swift Testing as the spec for
DesktopCore. - Skeleton. Package, socket protocol, caller identity port, and the MCP binary end to end on
desktop_apps. Use a separate socket and state folder so it runs next to the installed app. - Core tools: apps, windows, inspect, click, type, key, scroll, drag, hover, wait. Bench against the baseline; this is the go/no-go point.
- The remaining ~33 tools by family; each family is done when its
live-checkitems pass. - Cutover. Bundle the MCP binary, update the docs, keep an
npxshim for one release, then delete Peekaboo,native/patches,build.tsand the TS client.
Rough size: about 2–4 days in total, mostly step 4.
Benchmark plan
Pull live-check's MCP client out into a bench script that takes --server <command> and runs the same scenarios against node dist/mcp.js and the new binary, writing JSON results.
- Latency per tool, p50 and p95 over 20+ runs: apps, windows, inspect on TextEdit, Finder and a heavy Safari page, click with
expect, typing 200 characters, a wait that succeeds after 1s. - Scenario wall time for the
live-checkflows. - Correctness:
live-checkpass rate, flakiness over N repeats, field-level diffs of results. - Tokens returned per inspect (text and image bytes).
- AX IPC calls per inspect.
- Memory and CPU of the MCP server and the app, and MCP startup time.
- Dev loop: build and test times, lines of code, dependency count, bundle size.
- Add a no-op
pingop to separate handshake cost from the work itself.
First numbers, taken against the installed v0.14.1 app, calling the client directly without Node:
- Client spawn ending in a usage error: about 8 ms (a bare
/usr/bin/trueis about 4 ms) appsend to end: about 49 ms p50windowswith a non-existent pid, which fails: about 72 ms
Open questions
- Embedders: does anything besides Desktop Tools use the C ABI in
docs/embed.mdor the NodecreateDesktopAPI indocs/node.md? If not, drop both. If so, keep the C ABI exactly and make the Node API a thin wrapper. - Where it lives:
native2/on a branch in this repo, or a fresh repo.
- Langage dominant
- Swift
- Étoiles
- 0
- Forks
- 0
- Merge moyen
- 39 min
- PR mergées (30 j)
- 144
Préparer son environnement
Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de githubnext/desktop-tools
-
Ace: adopt desktopToolRules()Ouverteace documentation
Difficulté 2/5 1-3 heures Accessibilité débutants 79/100
githubnext/desktop-tools#104 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
githubnext/desktop-tools#179 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
githubnext/desktop-tools#178 ·
Les mainteneurs répondent en général sous 1 jour
-
No usable route to type into a web text field when the app loses keyboard focus between callsOuverte
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
githubnext/desktop-tools#177 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 3/5 1-2 jours Accessibilité débutants 67/100
githubnext/desktop-tools#176 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de githubnext/desktop-tools
Issues similaires
-
accessibility bug medium-priority mobile
Difficulté 2/5 1-3 heures Accessibilité débutants 83/100
lognorman20/monaco#6247 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
swiftlang/swift-format#1312 ·