Add file mode (executable bit) support to `push_files`

Ouverte Adaptée aux débutants
#2,578 0 commentaires 2 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
78/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Calme
Stack technique
github, go
Domaine
api, tooling

Piste de recherche

Commencez dans pkg/github/repositories.go, au niveau de la définition de l'outil push_files et de la boucle qui construit les entrées de l'arbre de Git Data API. Suivez le schéma d'entrée files[] et les valeurs par défaut existantes ; vérifiez ensuite que les modes acceptés et le comportement lorsque le mode est omis sont représentés de manière cohérente. La tâche est terminée lorsque push_files peut conserver le mode demandé, que les valeurs par défaut restent compatibles et que create_or_update_file reste hors périmètre.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Feature request: expose file mode (executable bit) on push_files

Use case

Agentic coding harnesses use this MCP server to publish files into a repo
on behalf of an LLM (issue execution, autonomous PR workflows, etc.).
When the work the agent is asked to produce is a shell script, build
helper, or other executable, the resulting file needs the executable
bit set (100755) — otherwise reviewers either have to chmod +x after
merge or merge a broken artifact.

Today there is no way for an MCP client to land an executable file
through this server. Both file-write tools use APIs that surface a fixed
mode:

  • create_or_update_file → Contents API (PUT /repos/.../contents/{path}),
    which always writes mode 100644. This is a GitHub API limitation, not
    something this server can route around.
  • push_files → Git Data API (CreateTree + CreateCommit +
    UpdateRef). The underlying API does support per-entry mode, but
    the tool's input schema doesn't expose it. Each entry is currently
    {content, path} only.

We've observed agents react to this in two unhelpful ways:

  1. Quiet hallucination. The agent reports in the PR body that it
    pushed with mode 100755 when in fact the blob landed as 100644.
  2. Workaround scope drift. The agent invents a second file (e.g.
    scripts/permissions.sh containing find scripts/ -exec chmod +x)
    that wasn't part of the task, hoping a CI step or human will run it.

A first-class mode parameter on push_files would close both failure
modes cleanly.

Proposed change

Extend the push_files.files[] input schema with an optional mode
field, validated against the set the Git Data API accepts:

Mode Meaning
100644 regular file (default if omitted)
100755 executable file
120000 symlink
040000 subdirectory (subtree)
160000 submodule

For most agentic use cases only 100644 (default) and 100755 matter,
but echoing the full Git Data API set keeps parity with the underlying
endpoint.

Backwards compatible: existing callers that omit mode get 100644,
which is what they get today.

Implementation pointer

The relevant code is already calling Git.CreateTree with a
[]*github.TreeEntry (in pkg/github/repositories.go, around the
PushFiles tool definition). The go-github TreeEntry struct
already has a Mode *string field — it just isn't being set from the
tool input. Threading it through should be a small change:

// in the loop that builds entries:
mode := "100644"
if f.Mode != nil {
    mode = *f.Mode
}
entries = append(entries, &github.TreeEntry{
    Path: github.String(f.Path),
    Mode: github.String(mode),
    Type: github.String("blob"),
    Content: github.String(f.Content),
})

Plus input-schema additions for the optional field with the validated
set above.

Single-file case

create_or_update_file can't be fixed the same way because the Contents
API doesn't support mode at all — it's a GitHub API constraint, not a
server constraint. For the single-file executable case, callers can use
push_files with a one-entry files array. Worth noting that in the
tool's description so clients pick the right call.

Out of scope

  • Changes to create_or_update_file (blocked by Contents API).
  • Symlink/submodule write flows beyond just accepting their modes on the
    schema.
  • Validating the executable-bit semantics on the receiving end.

Context

Filed against this server because we've been hitting the limitation
from a Claude-Code-plans / Goose-executes harness
(why-pengo/claude_and_goose),
where local-model executors are asked to ship small bash helpers as
part of issue-driven PRs. Happy to send a PR if the proposed shape
looks right.

Langage dominant
Go
Étoiles
33.1k
Forks
5k
Merge moyen
2 j 15 h
PR mergées (30 j)
27

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de github/github-mcp-server

Toutes les issues de github/github-mcp-server

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.