`gh stack` resolves the API repository from the `origin` remote, ignoring `--remote`, `gh repo set-default`, and its own state file — silently operating on the wrong repository in multi-remote clones
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 52/100
Piste de recherche
Commencez par suivre la résolution du dépôt depuis les points d’entrée gh stack init et gh stack submit, notamment --remote, GH_REPO, gh-resolved et le champ repository dans .git/gh-stack. Comparez le dépôt sélectionné avec le remote de push et vérifiez que les flux interactifs et --auto ciblent le dépôt prévu ou échouent explicitement lorsque la résolution est ambiguë.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Summary
In a clone with multiple remotes, every gh stack PR/stack API operation is bound to the repository of the origin remote, regardless of:
- the
--remoteflag (which only changes the push target), gh repo set-default/remote.<name>.gh-resolved(the standard gh CLI repo resolution),- the
repositoryfield in.git/gh-stack(editing it has no effect on subsequent runs).
If origin points at a different repository than the one your branches and PRs live in — the completely standard fork workflow where origin is upstream and you push to your fork — gh stack submit pushes to the right remote but then tries to create PRs and stacks on the wrong repository. In --auto / non-interactive mode this happens silently: there is no "Multiple remotes found" prompt (the interactive path in #219 at least shows one).
In my case the only reason no PRs were actually opened against the upstream project is that my branches don't exist there, so every createPullRequest failed. If upstream had happened to contain same-named branches, gh stack submit --auto would have opened a pile of PRs against a repository I never pointed it at. For agent/scripted use this is a dangerous default.
Environment
- gh version 2.96.0
- gh-stack v0.1.0
- Clone with 7 remotes;
origin=github.com/argoproj/argo-workflows(upstream),joibel=github.com/Joibel/argo-workflows(fork, where all stack branches and 8 open PRs live) gh repo set-default Joibel/argo-workflowsis set (remote.joibel.gh-resolved = base)
Steps to reproduce
- Clone a repo with
originpointing at upstream and a second remote pointing at your fork. - Create branches with open PRs on the fork (head and base both on the fork).
gh stack init --base <trunk> <branch1> ... <branchN>— adopts the branches fine, but records"repository": "github.com:<origin-owner>/<repo>"in.git/gh-stack.gh stack submit --remote <fork-remote> --auto
Observed
-
Push goes to the fork remote correctly ("Pushing to joibel... ✓ Pushed and synced 8 branches").
-
All PR operations target the
originrepository: existing fork PRs are not detected, and the extension attemptscreatePullRequestagainst upstream, failing with:⚠ failed to create PR for <branch>: creating PR: GraphQL: Head sha can't be blank, Base sha can't be blank, No commits between <base> and <branch>, Head ref must be a branch, Base ref must be a branch (createPullRequest)(Same error signature as #219, different root cause — here the refs genuinely don't exist because it's querying the wrong repository.)
-
The interactive TUI confirms it: the header shows
Repo: argoproj/argo-workflowseven when invoked with--remote joibel. -
None of the following change the target repository:
--remote,gh repo set-default, editing therepositoryfield in.git/gh-stack.
Workaround
GH_REPO=<fork-owner>/<repo> gh stack submit --remote <fork-remote> --auto works perfectly — existing PRs are detected ("PR #NN for is up to date") and the stack is created.
Expected
- Repo resolution should follow the standard gh CLI rules (
GH_REPO, thengh-resolved/gh repo set-default, then remote heuristics), or at minimum follow the remote selected with--remote, since a stack's branches and PRs must by definition (#46) live in the repository the branches are pushed to. - If resolution is ambiguous in non-interactive mode, fail with an explicit "multiple remotes, specify GH_REPO or --remote" error rather than silently picking
origin. gh stack initshould surface/validate which repository it bound the stack to.
Related
- #219 — same GraphQL error signature via a different resolution failure; its interactive run at least got a "Multiple remotes found" prompt, which
--autoskips. - #45, #337 — same code area (deriving the API repo from remote URLs) tripping on SSH aliases / hostname remaps.
- #46 — cross-fork stacks; confirms head+base must be one repository, which makes binding to
origindoubly wrong when pushes go elsewhere.
- Langage dominant
- Go
- Étoiles
- 1.5k
- Forks
- 73
- Merge moyen
- 1 j 8 h
- PR mergées (30 j)
- 7
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de github/gh-stack
-
Difficulté 2/5 1-3 heures Accessibilité débutants 85/100
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 92/100
-
feature request topic: cli - general
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
feature request topic: auto-merge
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
bug topic: docs
Difficulté 1/5 Moins d'une heure Accessibilité débutants 68/100
Toutes les issues de github/gh-stack
Issues similaires
-
area/dev-productivity area/disaster-recovery area/ipcei kind/enhancement
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 85/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
kind/bug status/0-triage
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
-
🤔 refinement needed
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
equinor/radix-operator#1979 ·