@sentry/cloudflare: Flue agents need a hand-written Durable Object wrapper
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Accessibilité débutants
- 35/100
- Type d'issue
- Fonctionnalité
- Clarté
- Plutôt claire
- Activité
- Active
- Stack technique
- typescript
- Domaine
- backend, cloud, observability-sre
Piste de recherche
Start with autoInstrument.ts, options.ts, and instrument.ts, then inspect the generated Flue worker shape and the cloudflare-mastra e2e app. Trace how createFlueAgentClass exposes each agent and verify the existing wrapping guard before choosing the applicable Agent or Durable Object wrapper. Done means Flue agents are instrumented without clobbering extensions, double-wrapping documented setups, or silently accepting an unmatched generated module.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Flue runs each agent in its own Durable Object, and nothing in the SDK runs Sentry.init() in that isolate. Users have to hand-write a wrapper module and re-export it from every agent module:
// src/sentry.ts
export const cloudflare = extend({
wrap: Final =>
Sentry.instrumentDurableObjectWithSentry((env: Env) => ({ dsn: env.SENTRY_DSN }), Final),
});
// src/agents/support.ts
export { cloudflare } from '../sentry.ts';
Miss the re-export in one agent module and that agent captures nothing, with no error anywhere. The Flue Cloudflare guide (getsentry/sentry-docs#19528) covers it with a warning and a troubleshooting entry, which is a weak fix for a silent failure.
Why auto-instrumentation doesn't cover it
sentryCloudflareAutoInstrumentPlugin is gated on wrangler's main, which resolveWranglerConfig reads from disk. Flue sets main to virtual:flue/worker and adds the DO bindings in memory, inside @cloudflare/vite-plugin's config hook, and never writes either to the file. Running wrangler's own reader against a real flue init app:
unstable_readConfig('<flue app>/wrangler.jsonc')
main : undefined
durable_objects.bindings : []
So entryFilePath is never assigned and transform returns on its first line (autoInstrument.ts:65). instrument.server.ts sits behind the same gate at autoInstrument.ts:51, so it is never probed either.
Contrast the cloudflare-mastra e2e app, whose wrangler.toml has main = "src/index.ts": a real file the user wrote that exports the classes. That is why Mastra works here and Flue does not.
Where to investigate
Flue's generated worker is a real module in the graph, and it exports each agent class from a fixed shape:
export const FlueHelloAgent = createFlueAgentClass({
AgentBase: Agent,
className: "FlueHelloAgent",
extension: Reflect.get(__flue_agent_module_0__, 'cloudflare'),
});
Wrapping the result there looks viable. Open questions:
- Where options come from.
getFinalOptionsalready readsenv.SENTRY_DSN(options.ts:68), so the env fallback may be enough and the setup could end up zero-config. Aninstrument.server.*probe would need a directory to start from, since there is no realmainto sit next to. - Not double-wrapping. Anyone on the documented setup applies the wrapper inside
createFlueAgentClass, which the build cannot see._INTERNAL_wrapUnlessInstrumented(instrument.ts:96) was built for this case; confirm it covers it before relying on it. - Which wrapper. Flue builds the class with
AgentBase: Agentfromagents, so it is a real Agent rather than a plain Durable Object.instrumentAgentWithSentrymay apply and carry more thaninstrumentDurableObjectWithSentry. - Failing loudly. The generated module is marked "Do not edit" and is not API. A transform that matches it should warn when it finds no
createFlueAgentClasscall, rather than silently shipping an uninstrumented worker.
One thing to rule out up front: do not reuse the extension slot. resolveCloudflareExtension reads exactly one cloudflare export per agent, with no array and no registry, so taking it would clobber a user's own extension.
- Langage dominant
- TypeScript
- Étoiles
- 8.7k
- Forks
- 1.9k
- Merge moyen
- 1 j 16 h
- PR mergées (30 j)
- 576
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de getsentry/sentry-javascript
-
Browser Bug Next.js Traces Waiting for: Product Owner
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
getsentry/sentry-javascript#24672 · 1 commentaire ·
-
javascript
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
getsentry/sentry-javascript#24200 · 2 commentaires ·
-
javascript Task
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
getsentry/sentry-javascript#24134 · 1 commentaire ·
-
Cloudflare Workers javascript Tests
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
getsentry/sentry-javascript#24051 · 1 commentaire ·
-
Bug Bun javascript
Difficulté 2/5 1-3 heures Accessibilité débutants 92/100
getsentry/sentry-javascript#24045 · 1 commentaire ·
Toutes les issues de getsentry/sentry-javascript
Issues similaires
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
-
Crush Ouverte
Difficulté 1/5 Moins d'une heure Accessibilité débutants 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Ouverte
Difficulté 1/5 Moins d'une heure Accessibilité débutants 90/100
ElementsProject/cln-application#167 · 1 commentaire · 1 réaction ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
Quantco/pnpm-licenses#17 ·
-
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100