Parallel builds on one machine can bundle each other's Python app (staging lives in the plugin's folder in the shared pub cache)
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Accessibilité débutants
- 38/100
Piste de recherche
Start with src/serious_python/bin/package_command.dart, src/serious_python_darwin/darwin/sync_site_packages.sh and stage_spm.sh, then inspect src/serious_python_android/android/build.gradle.kts and the reproduction steps. Compare how iOS, macOS and Android stage generated app data in the shared pub cache. Done means concurrent builds cannot package another project's app or partially written artifacts; the issue offers several possible fixes but does not specify a single design.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
What happens
Two builds of serious_python apps that run at the same time on one machine can ship each other's Python app. Nothing fails or warns: the app installs, starts and runs the other project's code.
We hit it three times in one evening (serious_python 5.0.0 through flet build ios-simulator from Flet 1.1, Flutter 3.47.7, Xcode 27, iOS 26.5 simulator), building one Flet app from several git worktrees in parallel:
- a build's own
build/python-app/(itsSERIOUS_PYTHON_APP) held a new module,ui/badges.pyc, but the installedRunner.app/serious_python_darwin_serious_python_darwin.bundle/app/did not; ~/.pub-cache/hosted/pub.dev/serious_python_darwin-5.0.0/darwin/dist_ios/app/had been rewritten a minute after that build packaged its app, by a parallel build in another worktree, and the installed bundle matched that copy;- in another case the app crashed at start on the other worktree's config file; the traceback paths named the other worktree's
build/site-packages.
Why
serious_python stages each app inside the plugin's own package directory, and Flutter resolves plugins from the pub cache, which every Flutter project on the machine shares. The per-project inputs (SERIOUS_PYTHON_APP, SERIOUS_PYTHON_SITE_PACKAGES) are fine; the shared copy they are staged into is not.
iOS and macOS (code at 16bceeb, identical to the published 5.0.0):
- The
packagecommand stages the processed app toSERIOUS_PYTHON_APP(per project), then runsprepare_spm.shinside the plugin'sdarwin/directory, which_resolveDarwinDir()finds through the project'spackage_config.json, i.e. in the pub cache:
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python/bin/package_command.dart#L593-L602
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python/bin/package_command.dart#L689-L741 sync_site_packages.shrsyncs$SERIOUS_PYTHON_APPinto$script_dir/dist_ios/appanddist_macos/app, and the site-packages and the frameworks built from them intodist_ios/site-packagesanddist_ios/site-xcframeworks:
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python_darwin/darwin/sync_site_packages.sh#L9-L22- Under Swift Package Manager (Flutter's default since 3.44),
stage_spm.shcopiesdist_ios/{stdlib,site-packages,app}into the package'sSources/serious_python_darwin/Resources/and the extension frameworks intoextra-xcframeworks/, whichPackage.swiftbundles as.copy("Resources/app")and binary targets:
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python_darwin/darwin/stage_spm.sh#L33-L48
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python_darwin/darwin/serious_python_darwin/Package.swift#L94-L104 - Under CocoaPods, the podspec's resource bundle points at the same folder:
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python_darwin/darwin/serious_python_darwin.podspec#L76-L82 - Xcode copies those folders into the app later, during
flutter build, which takes minutes. Another project'spackagestep in that window overwrites them, and the first build bundles the second one's app (and its site-packages and frameworks, which differ when the requirements differ).
Android has the same race, with a shorter window. serious_python_android's Gradle tasks write app.zip, stdlib.zip, sitepackages.zip and extract.zip to file("src/main/assets") and the native libraries to src/main/jniLibs/<abi>, paths relative to the plugin's project directory, which is its folder in the pub cache:
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python_android/android/build.gradle.kts#L151
https://github.com/flet-dev/serious-python/blob/16bceeb92851022aec9ad6ef24616a0831dc2ba6/src/serious_python_android/android/build.gradle.kts#L423-L454
AGP merges them into the APK later in the same Gradle run, so two Gradle builds whose preBuild and asset merge overlap can package each other's app.zip (or a half-written one). On the machine above, ~/.pub-cache/hosted/pub.dev/serious_python_android-5.0.0/android/src/main/assets/app.zip is simply the last app any project built.
Steps to reproduce
- Two Flet apps (or two copies of one) whose
main.pydiffer, for example one that shows "A" and one that shows "B". - Start
flet build ios-simulatorin both, a few seconds apart, with the default~/.pub-cache. - In each project compare the packaged app with what the bundle holds:
One of them reports the other project's files (onlydiff -rq build/python-app build/ios-simulator/*.app/serious_python_darwin_serious_python_darwin.bundle/app.keepshould differ). Running both apps shows the same letter.
Workaround
A pub cache per project: PUB_CACHE=<project>/build/pub-cache flet build .... On APFS, mkdir -p build && cp -cR ~/.pub-cache build/pub-cache makes it in a few seconds without using disk space. With it, each bundle's app/ matched its own build/python-app/ (checked on iOS and Android).
Suggested fix
Stage per Flutter project, never in the plugin's own folder:
- Android: write the generated zips and libraries under the plugin's Gradle build directory, which Flutter already places inside each app's
build/, and add them as source directories, for exampleval assetsDir = layout.buildDirectory.dir("generated/serious_python/assets")withandroid.sourceSets["main"].assets.srcDir(assetsDir), and the same forjniLibs. No layout change for callers. - iOS and macOS: the app tree is the part that changes on every build, and a SwiftPM resource must live inside its package, so either:
- take the app out of the plugin package: copy
$SERIOUS_PYTHON_APPinto the app bundle at build time (a script phase reading the variable thatflet buildalready passes toflutter build), and let the runtime look forapp/there; or - stage into a per-project copy of the plugin's
darwin/directory (SERIOUS_PYTHON_DARWIN_DIRalready overrides where staging happens) and have the caller point Flutter at that copy, e.g.flet buildwriting adependency_overridespath underbuild/.
- take the app out of the plugin package: copy
- At least, detect it: record a hash of
SERIOUS_PYTHON_APPwhen staging and compare it with what was bundled at the end of the build (or haveflet buildcomparebuild/python-appwith the bundle'sapp/), and fail with a clear message instead of shipping the wrong app.
Written by Claude Code (AI agent).
- Langage dominant
- Dart
- Étoiles
- 325
- Forks
- 46
- Merge moyen
- 20 h 18 min
- PR mergées (30 j)
- 5
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Aucun modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de flet-dev/serious-python
-
Difficulté 4/5 3-5 jours Accessibilité débutants 45/100
flet-dev/serious-python#226 ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 35/100
flet-dev/serious-python#169 ·
-
iOS Build Failure: Missing site-xcframeworks Directory in serious_python_darwin PhaseScriptExecutionOuverte
Difficulté 3/5 1-2 jours Accessibilité débutants 42/100
flet-dev/serious-python#168 ·
-
Update docs for site-packagesPeut-être à nouveau libre @FeodorFitsner l’a pris il y a 576 jours, et aucune pull request n’est ouverte. Ouvertedocumentation
flet-dev/serious-python#157 · 1 commentaire · 1 personne assignée ·
-
Difficulté 4/5 3-5 jours Accessibilité débutants 35/100
flet-dev/serious-python#133 · 2 commentaires ·
Toutes les issues de flet-dev/serious-python
Issues similaires
-
area: ui feature priority: medium
Difficulté 1/5 Moins d'une heure Accessibilité débutants 90/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 63/100
AimesSoft/NipaPlay-Reload#1022 ·
Les mainteneurs répondent en général sous 1 jour
-
`jwtPayload.roomConfiguration` returns null fields for tokens from LiveKit server SDKsPeut-être pris @RaphaelFakhri l’a pris aujourd’hui. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
livekit/client-sdk-flutter#1243 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
maplibre/flutter-maplibre-gl#1094 ·
Les mainteneurs répondent en général sous 1 jour
-
bug to check
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
Les mainteneurs répondent en général sous 1 jour