Preserve scalar slots assigned through localized glob aliases

Fermée
  • Quelque chose ne va pas ?
#1,939 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Une pull request liée a déjà été fusionnée.

  • #1944 par @fglock — fusionnée

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
java, perl
Domaine
backend

Piste de recherche

Start with the reproducer in the issue: a localized whole-glob alias (local *SYM = *{...}) followed by *SYM = \$value. The issue points to RuntimeGlob.set and getGlobAliasGroup(this.globName) as the place where the scalar slot is written to the wrong glob. Run the snippet on both the JVM and interpreter backends. Done when it prints /tmp/example-state on both, and a permanent regression test covers scalar-slot assignment through a localized glob alias.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:runtime bug

Summary

PerlOnJava loses the destination scalar slot when a scalar reference is assigned through a localized whole-glob alias. Text::Template 1.61 uses this pattern to expose HASH values to template fragments; those variables become undefined in the template.

Minimal reproducer

use strict;
use warnings;
my $package = 'Probe';
my $name = 'state_dir';
my $value = '/tmp/example-state';
{
    no strict 'refs';
    local *SYM = *{"${package}::$name"};
    *SYM = \$value;
    print defined ${"${package}::$name"}
        ? ${"${package}::$name"} : '<undef>', "\n";
}

System Perl prints /tmp/example-state. PerlOnJava 5.44.1 prints an empty value (with an uninitialized-value warning) on both JVM and interpreter backends.

CPAN evidence

In CPAN random-tester run 20261030-095654-34969, App-Milter-Limit 0.54 fails t/limit-from.t and t/smoke.t on PerlOnJava. Both tests provide a temporary state_dir in their generated config, but Text::Template expands it to an empty string. App-Milter-Limit then applies its /var/run/milter-limit default and fails to create that directory due to permissions.

The archived system-Perl oracle passes the complete App-Milter-Limit suite: 6 test files and 21 tests. The PerlOnJava suite reports 2/6 test programs failed. The relevant environment was macOS 26.7.1 arm64, Java 24.0.2, PerlOnJava 5.44.1 (4dc1a6f4d), and system Perl 5.42.2.

Root cause

Text::Template's _install_hash uses local *SYM = *{"${dest}::$name"} and then assigns *SYM = \$val. PerlOnJava handles the reference assignment in RuntimeGlob.set by updating the scalar slot for getGlobAliasGroup(this.globName). In this localized alias case, the alias group associated with SYM does not carry the destination glob identity, so the destination package scalar remains undefined. The failure is reproducible without Text::Template using the snippet above.

Related, but distinct, reports: #1258 covers direct dynamic package-scalar aliasing; #1630 covered whole-glob aliases and localized IO replacements.

Acceptance criteria

  • The reproducer prints /tmp/example-state on system Perl and both PerlOnJava backends.
  • Add permanent project-owned regression coverage for scalar-slot assignment through a localized whole-glob alias.
  • App-Milter-Limit 0.54 passes all tests on both PerlOnJava backends.
Langage dominant
Perl
Étoiles
65
Forks
8
Merge moyen
5 h 52 min
PR mergées (30 j)
175

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fglock/PerlOnJava

Toutes les issues de fglock/PerlOnJava

Issues similaires

Plus d'issues Perl

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.