Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Log4j 2.7 log correlation calls ThreadContext.removeAll, which was introduced in 2.8

Ouverte
  • Quelque chose ne va pas ?
#4,593 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
java
Domaine
observability

Piste de recherche

Start with Log4j2_7PlusLogCorrelationHelper.removeFromMdc in the apm-log4j2-plugin, which calls ThreadContext.removeAll, and with the version check in Log4j2LogCorrelationInstrumentation that selects log4j-core 2.7 and above. Decide whether to replace the call with per-key ThreadContext.remove for 2.7 or gate the instrumentation, then check that the reproduction no longer throws NoSuchMethodError. Done means a regression test passes for both 2.7 and 2.8+, including cleanup after logging and thread reuse.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

agent-java community triage

Describe the bug

Elastic APM Java agent 1.57.0 emits repeated NoSuchMethodError messages when log correlation is used with Log4j 2.7:

ERROR co.elastic.apm.agent.bci.IndyBootstrap - Advice threw an exception, this should never happen!
java.lang.NoSuchMethodError: org.apache.logging.log4j.ThreadContext.removeAll(Ljava/lang/Iterable;)V
    at co.elastic.apm.agent.log4j2.correlation.Log4j2_7PlusLogCorrelationHelper.removeFromMdc(Log4j2_7PlusLogCorrelationHelper.java:47)
    at co.elastic.apm.agent.loginstr.correlation.AbstractLogCorrelationHelper.afterLoggingEvent(AbstractLogCorrelationHelper.java:54)

The application continues running, but ordinary logging during traced requests repeatedly triggers the error. This is not limited to startup.

Relevant versions: Java 8; log4j-api and log4j-core both 2.7; Elastic APM Java agent 1.57.0.

Steps to reproduce

Suggested minimal reproduction, derived from the observed error and source analysis (not yet independently executed as a standalone test):

  1. Use matching org.apache.logging.log4j:log4j-api:2.7 and org.apache.logging.log4j:log4j-core:2.7 dependencies.
  2. Start with agent 1.57.0, leaving log-correlation instrumentation enabled.
  3. Emit an enabled log event while an APM transaction is active, for example:
Transaction transaction = ElasticApm.startTransaction();
try (Scope scope = transaction.activate()) {
    LogManager.getLogger("example").info("correlation test");
} finally {
    transaction.end();
}

Here ElasticApm, Transaction, and Scope are from co.elastic.apm.api, and LogManager is from org.apache.logging.log4j.

Expected behavior

Log correlation should avoid invoking an API absent from the selected Log4j version. If Log4j 2.7 is supported, correlation IDs should be added and cleaned up without an exception. Otherwise the incompatible instrumentation should not be selected for 2.7.

Source analysis

The same version/API mismatch is present in main at commit 5cabf9ceeaea99f7a811b896064bf7aa8b131e5d (source inspected; that commit was not runtime-tested):

A possible fix is a compatible per-key ThreadContext.remove(String) cleanup for 2.7, or a separate version/capability-gated implementation. A regression test should cover 2.7 specifically, as well as 2.8+, including cleanup after logging and thread reuse.

This differs from #3745 / #3764: those address version detection in shaded JARs; here the application actually uses Log4j 2.7 and lacks the invoked API.

Workaround

Upgrade the application's matching Log4j dependencies to a compatible maintained version, or disable log-correlation temporarily, accepting the loss of automatic logging correlation.

Langage dominant
Java
Étoiles
593
Forks
338
Merge moyen
1 j 9 h
PR mergées (30 j)
13

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de elastic/apm-agent-java

Toutes les issues de elastic/apm-agent-java

Issues similaires

Plus d'issues Java

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.