VS Code: a revocation whose save failed lasts until the broker window closes, not until Dormouse quits

Fermée
  • Quelque chose ne va pas ?
#1,484 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
À clarifier
Activité
Active
Stack technique
typescript
Domaine
documentation, security

Piste de recherche

Start by reading docs/specs/remote-security-model.md (Revocation section) and lib/src/host/remote/service.ts around lines 539 and 1199 to see how #unsavedRevocations and the error text work. Note vscode-ext/src/burrow.ts starts the service only in the broker window. Done depends on maintainer's call: either edit those texts or hand pending revocations to the next broker.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

In VS Code, a phone revocation whose ACL save failed lasts only as long as the broker window, not until Dormouse quits. docs/specs/remote-security-model.md → "Revocation" says "quitting Dormouse before one undoes it". The error the user sees says "refused until Dormouse quits". In VS Code, closing one window is enough.

How it happens. #unsavedRevocations is held in memory on a single BurrowService (service.ts#L539). VS Code runs that service only in the broker window (startService in vscode-ext/src/burrow.ts). When the broker window closes and another window takes over, the new service loads the stored ACL, which never received the revocation, so the revoked phone is paired again. Standalone runs one sidecar per app, so the spec's wording is accurate there.

This only happens after an ACL save has already failed, which is rare. Two directions, and the choice is a maintainer's:

  • Narrow the promise. Change the spec sentence and the error text to say the refusal lasts until the window running remote control closes, or until Dormouse quits.
  • Keep the promise. Hand pending revocations to the next broker, either through the peer link at handoff or a small separate record. A record has to be written somewhere, and the ACL write just failed, so this is the larger change.
A related note from the same review of #1459 (not a bug)
  • The public BurrowService.revoke (service.ts#L1172) has no caller, tests included. Settings and dor remote revoke both go through #revokeDevice. security-remote.md S292 and the spec's passkey-target sentence name it as the entry point.
Langage dominant
TypeScript
Étoiles
5
Forks
1
Merge moyen
11 h 41 min
PR mergées (30 j)
432

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de diffplug/dormouse

Toutes les issues de diffplug/dormouse

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.