ObjectRef.full_path: the file branch and plugin storage protocols still build the path by hand

Ouverte
#1,679 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 6 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
python

Piste de recherche

Start with src/datajoint/objectref.py and inspect ObjectRef.full_path alongside StorageBackend._full_path; the issue identifies the file branch, plugin storage branch, and location normalization as the affected paths. Read the tests for object references and storage adapters, then add coverage for the reported behaviors, including a literal path that pins current location handling. Done means the return behavior for file references is decided and the plugin branch includes its store location without changing existing object keys.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Follow-up to #1646 and #1648. #1648 makes ObjectRef.full_path use the backend's get_url() for s3, gcs and azure stores, so the location is included. Two other branches of full_path (src/datajoint/objectref.py) still build the path themselves:

  • file protocol: returns str(Path(location) / self.path). On Windows this gives backslashes, the path is not made absolute, and the docstring promises a URI while this branch returns a plain path. Switching it to get_url() would return file:///... and break callers that do open(ref.full_path), so the return type needs an explicit decision, or the branch should use _full_path.
  • Any other protocol (storage adapters registered through the datajoint.storage entry point): returns the bare self.path, without the store location, which is the same bug as #1646. StorageAdapter already provides get_url and full_path, so return self._backend.get_url(self.path) would fix it.

Separately, StorageBackend._full_path does not normalize the location: "proj/outbox/" gives s3://bkt/proj/outbox//.... That is consistent with where objects are written today, so changing it would move the keys of existing stores. A test that pins the current behavior with a literal path would make any later change deliberate.

Langage dominant
Python
Étoiles
198
Forks
103
Merge moyen
6 j 1 h
PR mergées (30 j)
10

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de datajoint/datajoint-python

Toutes les issues de datajoint/datajoint-python

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.