drop() leaves the jobs table behind, and a table re-declared under the same name inherits it

Ouverte
#1,601 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 6 jours

@dimitri-yatsenko y travaille déjà.

Depuis le 17/10/2026.

  • #1615 par @dimitri-yatsenko — ouverte

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
25/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
mysql, python

Piste de recherche

Start with table.py:1224 (drop_quick) and the lazy jobs-table creation in autopopulate.py:182-188. Trace how AutoPopulate.jobs validates and uses the jobs table, then update the drop behavior and add the primary-key compatibility check. The issue is done when dropping a table also removes its jobs table and an existing mismatched jobs table raises an error.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Summary

drop() removes an auto-populated table but not its jobs table, ~~<table_name>. drop_quick() (table.py:1224) drops only full_table_name. The jobs table is created lazily by AutoPopulate.jobs (autopopulate.py:182-188), and nothing else removes it, so it stays, with its records and its primary key.

When a table is later declared under the same name, its jobs property picks up the old jobs table. If the new table's primary key differs, populate(reserve_jobs=True) computes nothing and raises no error. refresh() adds key_source - target - jobs, and the old records, keyed on part of the new primary key, cover every new key.

Reproduction

DataJoint 2.3.5.dev8 (master, a00b89f5), MySQL 8.0.46, Python 3.11:

import datajoint as dj

schema = dj.Schema("scratch_drop_jobs")

@schema
class Item(dj.Manual):
    definition = """
    item : int32
    """

@schema
class Param(dj.Lookup):
    definition = """
    param : int32
    """
    contents = [(1,), (2,)]

@schema
class Result(dj.Computed):
    definition = """
    -> Item
    ---
    value : int32
    """

    def make(self, key):
        raise RuntimeError("not ready")

Item.insert({"item": i} for i in range(3))
Result.populate(reserve_jobs=True, suppress_errors=True)
Result.drop(prompt=False)
print("tables after drop:", [r[0] for r in schema.connection.query("SHOW TABLES FROM `scratch_drop_jobs`")])

@schema
class Result(dj.Computed):  # same name, primary key now includes Param
    definition = """
    -> Item
    -> Param
    ---
    value : int32
    """

    def make(self, key):
        self.insert1(dict(key, value=1))

print("jobs primary key:", Result.jobs.heading.primary_key, "records:", [j["status"] for j in Result.jobs.to_dicts()])
Result.populate(reserve_jobs=True)
print("rows after populate(reserve_jobs=True):", len(Result()), "of", len(Result.key_source))

Output:

tables after drop: ['#param', 'item', '~lineage', '~~result']
jobs primary key: ['item'] records: ['error', 'error', 'error']
rows after populate(reserve_jobs=True): 0 of 6

Expected behavior

  • drop() drops each table's jobs table along with the table, as it already removes the table's ~lineage entries.
  • AutoPopulate.jobs checks that an existing jobs table's primary key matches the table's, and raises if it does not. That also catches jobs tables left behind by earlier releases.
Langage dominant
Python
Étoiles
198
Forks
103
Merge moyen
6 j 1 h
PR mergées (30 j)
10

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de datajoint/datajoint-python

Toutes les issues de datajoint/datajoint-python

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.