refactor(host): explicit host for configuration reads and one entered runtime store

Fermée
  • Quelque chose ne va pas ?
#3,794 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
25/100
Type d'issue
Refactorisation
Clarté
Plutôt claire
Activité
Active
Stack technique
node.js, typescript
Domaine
backend, devtools

Piste de recherche

Start with the root platform-runtime-* files, platform packages, and defineRuntimeSlots modules; trace the remaining commandHostEnvironment() calls and runtime slot handles. Read the follow-ups #3763 and #3772 and the holistic review on #3747 for decisions already made. Done means configuration reads use the runtime's explicit host, one runtime-owned store is entered and disposed, and the daemon host test plus two-runtime isolation tests pass.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

in-progress ready-for-agent refactor

Part of #3747. Follow-up to #3763 and #3772, which leave two pieces deferred in their PR bodies.

1. Narrow commandHostEnvironment() to command execution

About 60 call sites remain in the root platform-runtime-* files and the platform packages. They read configuration (toolchain and SDK paths, caches, path resolution) through the ambient, AsyncLocalStorage-bound commandHostEnvironment(). The holistic review on the stack decided:

  • Configuration reads take the host explicitly. Pass it as a parameter, through the runtime deps, or through a port bound at construction.
  • The ambient lookup is only for host-kit command execution and diagnostics.

Done when:

  • Every non-test call of commandHostEnvironment() outside host-kit's command execution and diagnostics is replaced by an explicit host.
  • A test on the daemon route proves configuration is read from the runtime's host and not from the process, when the two differ.

2. One entered runtime store

#3772 moved per-runtime state onto defineRuntimeSlots. Each module still exposes its own handle, collected into runtimeStates.

Required:

  • Collapse them into one store, entered once per runtime.
  • Modules declare slots; the runtime owns entry and disposal.

Done when:

  • No module-level handle or runtimeStates aggregation remains.
  • The two-runtime isolation tests (Apple runner, Android helper, PNG worker, daemon modules) still pass.

Ordering

  • #3757 (agent-device/host) does not depend on this issue.
  • #3753 (lint gate) should land after part 1, so the gate can also forbid commandHostEnvironment() outside the command-execution boundary.
Langage dominant
TypeScript
Étoiles
5.2k
Forks
359
Merge moyen
13 h 23 min
PR mergées (30 j)
655

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de callstack/agent-device

Toutes les issues de callstack/agent-device

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.