bug: incorrect pagination in Memory Session Manager `list_messages`

Ouverte
#346 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
58/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Calme
Stack technique
python
Domaine
api, backend

Piste de recherche

Commencez dans session_manager.py, au niveau de list_messages, et examinez comment memory_client.list_events applique max_results et comment events_to_messages ignore les événements d’état. Reproduisez le cas avec des actor IDs partagés et des événements d’état de session ou agent, puis ajoutez une couverture de tests unitaires ou d’intégration ; le travail est terminé lorsque la pagination renvoie les messages demandés ou expose un nextToken lorsque d’autres messages existent.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Problem

Before PR #244

State events and conversational events were naturally separated by actorId:

# create_session used a prefixed actorId
create_event(actorId="session_my-session-id", payload=[{"blob": ...}])

# create_agent used a prefixed actorId
create_event(actorId="agent_my-agent-id", payload=[{"blob": ...}])

# create_message used the regular actorId
create_event(actorId="my-actor-id", payload=[{"conversational": ...}])

So when list_messages called list_events with actorId="my-actor-id", it only got conversational events back. State events lived under different actorIds and were invisible to this query. max_results counted only
what mattered.

After PR #244

Everything now uses the same actorId, with metadata distinguishing state events:

# create_session — same actorId, metadata marks it as state
create_event(
    actorId="my-actor-id",  # ← same as messages now
    metadata={"stateType": {"stringValue": "SESSION"}},
    payload=[{"blob": ...}],
)


# create_agent — same actorId, metadata marks it as state
create_event(
    actorId="my-actor-id",  # ← same as messages now
    metadata={"stateType": {"stringValue": "AGENT"}, "agentId": {"stringValue": "..."}},
    payload=[{"blob": ...}],
)

# create_message — same actorId, no metadata
create_event(actorId="my-actor-id", payload=[{"conversational": ...}])
Potential Issues

list_messages in session_manager.py fetches events without any metadata filter:

events = self.memory_client.list_events(
    memory_id=self.config.memory_id,
    actor_id=self.config.actor_id,
    session_id=session_id,
    max_results=max_results,  # ← this now includes state events in the count
)

Since all events share the same actorId now, this query returns both conversational AND state events. The API returned max_results events total, some of which were state events. Those get discarded by the converter, so the final list is shorter than what the caller asked for.

Concrete example

A session with 1 session state event, 2 agent state events, and 20 conversational messages. Customer calls list_messages(limit=10):

  1. max_results = limit + offset = 10
  2. list_events returns 10 events: 3 state + 7 conversational
  3. events_to_messages discards the 3 state events → 7 messages
  4. Customer gets 7 messages, expected 10

Customer does not get a pagination token, so they assume 7 is all that exists, and doesn't know there are more.

Acceptance Criteria
  • customer should be given nextToken, or should always get maxResults exactly if more results exist.
  • unit tests and/or integration verifying fix of the bug.
Langage dominant
Python
Étoiles
786
Forks
163
Merge moyen
4 h
PR mergées (30 j)
22

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de aws/bedrock-agentcore-sdk-python

Toutes les issues de aws/bedrock-agentcore-sdk-python

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.