CF cannot preprocess the stack when a module parameter appears in the conditions block and using a !Ref or !GetAtt function

Ouverte
#1,098 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
aws, python
Domaine
cli, cloud

Piste de recherche

Commencez par reproduire l’échec avec module1.yml, module2.yml et le modèle parent, en suivant les commandes cfn init, validate et submit avant de créer la stack de test. Suivez le traitement du paramètre du module et de la condition, puis vérifiez que la stack est créée sans l’erreur de dépendances non résolues.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Description

When using a CF module, if you use an intrincic function expression to assign the value of module parameter, and the template source of the module uses the parameter name in a condition, CF cannot preprocess the stack and exits with error

CloudFormation failed to preprocess the stack: 
  Template format error: 
    Unresolved dependencies [resSampleModule1resSourceQueue]. Cannot reference resources in the Conditions block of the template

Steps to reproduce

1. Create a module called Fujitsu::CF::SampleModule1::MODULE using the template module1.yml as fragment:
module1.yml
===========
AWSTemplateFormatVersion: 2010-09-09
Description: "Template to generate an example module with name Fujitsu::CF::SampleModule1::MODULE"

Parameters:

  parMaxReceiveCount:
    Description: Number of times a message is received by a consumer of the source queue before being moved to the dead-letter queue
    Type: Number
    Default: 3

Resources:

  resDeadLetterQueue: 
    Type: AWS::SQS::Queue
    
  resSourceQueue: 
    Type: AWS::SQS::Queue
    Properties: 
      RedrivePolicy: 
        deadLetterTargetArn: 
          Fn::GetAtt: 
            - "resDeadLetterQueue"
            - "Arn"
        maxReceiveCount: !Ref parMaxReceiveCount

Commands:

mkdir module1
cd module1
cfn init -t Fujitsu::CF::SampleModule1::MODULE -a MODULE --region eu-west-1
Replace fragmets/sample.json with module1.yml
cfn validate
cfn submit --region eu-west-1 --set-default
2. Create a module called Fujitsu::CF::SampleModule2::MODULE using the template module2.yml as fragment:
module2.yml
===========
AWSTemplateFormatVersion: 2010-09-09
Description: "Template to generate a samplemodule with name Fujitsu::CF::SampleModule2::MODULE"

Parameters:

  parBucketName:
    Description: S3 bucket name. If not specified, the S3 service assigns a name
    Type: String

  parVersioningConfiguration:
    Description: If versioning is enabled (Enabled) or disabled (Suspended)
    Type: String
    AllowedValues: ["Enabled","Suspended"]

Conditions:

  cndIsBucketNameSpecified: !Not
    - !Equals
      - ""
      - !Ref parBucketName

Resources:

  resS3Bucket:
    Type: 'AWS::S3::Bucket'
    Properties:
      BucketName: !If
        - cndIsBucketNameSpecified
        - !Sub ${parBucketName}-${AWS::Region}-${AWS::AccountId}
        - !Ref AWS::NoValue
      VersioningConfiguration:
        Status: !Ref parVersioningConfiguration

Outputs:

  outBucketName:
    Description: S3 bucket name
    Value: !Ref resS3Bucket

Commands:

mkdir module2
cd module2
cfn init -t Fujitsu::CF::SampleModule2::MODULE -a MODULE --region eu-west-1
Replace fragmets/sample.json with module2.yml
cfn validate
cfn submit --region eu-west-1 --set-default
3. Create a stack (called test in the image), from this template:
AWSTemplateFormatVersion: 2010-09-09
Description: "Sample parent template that uses Fujitsu::CF::SampleModule1::MODULE and Fujitsu::CF::SampleModule2::MODULE"

Parameters:

  parMaxReceiveCount:
    Description: Number of times a message is received by a consumer of the source queue before being moved to the dead-letter queue
    Type: Number
    Default: 3

Resources:

  resSampleModule1:
    Type: Fujitsu::CF::SampleModule1::MODULE
    Properties:
      parMaxReceiveCount: !Ref parMaxReceiveCount

  resSampleModule2:
    Type: Fujitsu::CF::SampleModule2::MODULE
    Properties:
      parBucketName: !GetAtt [resSampleModule1, resSourceQueue.QueueName]
      parVersioningConfiguration: "Suspended"

I will refer to this as the 'parent template'.

Expected behavior

The stack is created without errors.

Actual behavior

CF reports an error:

CloudFormation failed to preprocess the stack: 
  Template format error: 
    Unresolved dependencies [resSampleModule1resSourceQueue]. Cannot reference resources in the Conditions block of the template
bug-cf

The problem is the parent template uses an intrinsic function expression to assign value to a module parameter (parBucketName: !GetAtt [resSampleModule1, resSourceQueue.QueueName]), and the template fragment of the module uses the name of the assigned parameter (parBucketName) in a condition (cndIsBucketNameSpecified).

I think this is a bug because parBucketName in template fragment must be a name internal to the module.

Langage dominant
Python
Étoiles
336
Forks
173
Métriques de merge des PR
Aucune PR mergée en 30 j

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de aws-cloudformation/cloudformation-cli

Toutes les issues de aws-cloudformation/cloudformation-cli

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.