[Laravel] Optional BelongsTo relation cannot be set to null (500 on POST/PATCH)
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 54/100
Piste de recherche
Start with EloquentPropertyMetadataFactory.php and PersistProcessor.php in api-platform/laravel; trace how nullable BelongsTo and MorphTo values are handled during denormalization and persistence. Check the existing metadata and persistence tests for relation coverage, then reproduce the POST and PATCH cases with an explicit null. Done means optional to-one relations accept null and clear the foreign key without causing a 500.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
API Platform version(s) affected: 5.0.2 (api-platform/laravel, api-platform/serializer, api-platform/state, api-platform/metadata all 5.0.2)
Laravel 13.35.0, PHP 8.4.25
Description
An optional BelongsTo relation (foreign key column is nullable) rejects an explicit null on both POST and PATCH with a 500:
Symfony\Component\Serializer\Exception\NotNormalizableValueException:
The type of the "category" attribute must be "array" (nested document) or "string" (IRI), "NULL" given.
So a client can create the resource by omitting the key, but it can never clear the relation once it is set.
Two things combine to cause it:
ApiPlatform\Laravel\Eloquent\Metadata\Factory\Property\EloquentPropertyMetadataFactorywraps the native type of a plain column inType::nullable()when the column is nullable (if ($p['nullable'])), but for a relation it always doesType::object($relation['related'])and never looks at the foreign key column. The property is therefore non-nullable, andAbstractItemNormalizer::createAndValidateAttributeValue()does not short-circuit onnull(null === $value && $type->isNullable()), so it falls through todenormalizeRelation()which throws.- Even if the type is made nullable by hand (
nativeType: Type::nullable(Type::object(...))on#[ApiProperty]),ApiPlatform\Laravel\Eloquent\State\PersistProcessor::process()doesif (!isset($data->{$relation['name']})) { continue; }. Anullrelation is skipped,nullstays as a raw Eloquent attribute named after the relation, and the insert/update fails withSQLSTATE[42703]: column "category" of relation "shipping_methods" does not exist.
This works with API Platform on Symfony + Doctrine: Symfony\Bridge\Doctrine\PropertyInfo\DoctrineExtractor returns Type::nullable(Type::object($class)) for a single-valued association unless it is an identifier or a join column is explicitly nullable: false (isAssociationNullable()), so the same AbstractItemNormalizer accepts null and the association is simply set to null. The Eloquent metadata factory has no equivalent for BelongsTo.
Sending an empty string is not an alternative: it is treated as an IRI (Invalid IRI "" / No resource associated to "", 500).
Note: the failure is reported as a 500, while a NotNormalizableValueException for a bad payload is a client error elsewhere.
How to reproduce
Migration (relation column is nullable):
Schema::create('categories', function (Blueprint $table) {
$table->uuid('id')->primary();
$table->string('name');
});
Schema::create('items', function (Blueprint $table) {
$table->uuid('id')->primary();
$table->string('code');
$table->foreignUuid('category_id')->nullable()->constrained('categories')->nullOnDelete();
$table->timestamps();
});
Models:
use ApiPlatform\Metadata\ApiResource;
use Illuminate\Database\Eloquent\Concerns\HasUuids;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
#[ApiResource]
class Category extends Model
{
use HasUuids;
protected $fillable = ['name'];
}
#[ApiResource]
class Item extends Model
{
use HasUuids;
protected $fillable = ['code'];
public function category(): BelongsTo
{
return $this->belongsTo(Category::class);
}
}
Requests:
POST /api/items {"code": "a"} -> 201 (relation omitted)
POST /api/items {"code": "a", "category": null} -> 500
PATCH /api/items/{id} {"category": "/api/categories/{uuid}"} -> 200
PATCH /api/items/{id} {"category": null} -> 500
PATCH /api/items/{id} {"category": ""} -> 500 (Invalid IRI "")
Possible Solution
Two small changes in api-platform/laravel (sketch against 5.0.2, not run against the vendor code itself; the workaround at the end is what we verified).
-
Eloquent/Metadata/Factory/Property/EloquentPropertyMetadataFactory.php: make an optionalBelongsTonullable, as already done for plain columns.Note that
ModelMetadata::getAttributes()skips theBelongsToforeign key columns, so the nullability has to be read from the schema for$relation['foreign_key'].
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
@@ public function create(string $resourceClass, string $property, array $options = []): ApiProperty
$type = Type::object($relation['related']);
if ($collection) {
$type = Type::iterable($type);
+ } elseif (is_a($relation['type'], BelongsTo::class, true) && $this->isForeignKeyNullable($model, $relation['foreign_key'])) {
+ // same rule as Symfony's DoctrineExtractor::isAssociationNullable()
+ $type = Type::nullable($type);
}
@@
+ private function isForeignKeyNullable(Model $model, ?string $foreignKey): bool
+ {
+ if (null === $foreignKey) {
+ return false;
+ }
+
+ foreach ($model->getConnection()->getSchemaBuilder()->getColumns($model->getTable()) as $column) {
+ if ($column['name'] === $foreignKey) {
+ return (bool) $column['nullable'];
+ }
+ }
+
+ return false;
+ }
(In a real patch the columns should come from the schema already cached in ModelMetadata instead of querying them again.)
Eloquent/State/PersistProcessor.php: an explicitnullon a to-one relation must clear it instead of being skipped and written as a raw column.
foreach ($this->modelMetadata->getRelations($data) as $relation) {
+ if (
+ (BelongsTo::class === $relation['type'] || MorphTo::class === $relation['type'])
+ && \array_key_exists($relation['name'], $data->getAttributes())
+ && null === $data->getAttributes()[$relation['name']]
+ ) {
+ // explicit null: clear the foreign key and drop the pseudo attribute so it is not saved as a column
+ $data->{$relation['method_name']}()->dissociate();
+ unset($data->{$relation['name']});
+
+ continue;
+ }
+
if (!isset($data->{$relation['name']})) {
continue;
}
Together, {"category": null} on POST/PATCH sets the foreign key to null, like it does with Doctrine on Symfony.
Workaround we verified in our app (API Platform 5.0.2, all 56 tests of the resource pass): on the Eloquent model, declare the type and add a set-mutator.
use Symfony\Component\TypeInfo\Type;
#[ApiProperty(
serialize: new Groups(['item:read', 'item:write']),
property: 'category',
nativeType: new Type\NullableType(new Type\ObjectType(Category::class)),
)]
class Item extends Model
{
// ...
// API Platform assigns the relation as an attribute and only associates it when it is set,
// so null would otherwise be written as a raw "category" column.
public function setCategoryAttribute(mixed $value): void
{
if ($value === null) {
$this->category()->dissociate();
return;
}
$this->attributes['category'] = $value;
}
}
If the relation is validated with a Laravel FormRequest rule, it also needs nullable (e.g. ['sometimes', 'nullable', new MyIriRule()]), otherwise the rule receives null.
Additional Context
- The same applies to any optional
BelongsTo/MorphToon an Eloquent resource, not only to this example. - Stack trace (create with
"category": null):
Symfony\Component\Serializer\Exception\NotNormalizableValueException: The type of the "category" attribute must be "array" (nested document) or "string" (IRI), "NULL" given.
#0 vendor/api-platform/serializer/AbstractItemNormalizer.php(700): ...::createForUnexpectedDataType(...)
#1 vendor/api-platform/serializer/AbstractItemNormalizer.php(1083): ...->denormalizeRelation('category', ...)
#2 vendor/api-platform/serializer/AbstractItemNormalizer.php(1006): ...->createAndValidateAttributeValue('category', NULL, 'json', ...)
- Langage dominant
- PHP
- Étoiles
- 2.6k
- Forks
- 987
- Merge moyen
- 2 j 5 h
- PR mergées (30 j)
- 73
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de api-platform/core
-
API Platform ignores array shapes in the JSON SchemaPeut-être pris @afraca l’a pris il y a 7 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 78/100
api-platform/core#8766 ·
Les mainteneurs répondent en général sous 1 jour
-
SortFilter generates unsupported array form for parametersPeut-être pris Une pull request liée à cette issue est ouverte ou déjà fusionnée. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
api-platform/core#8744 ·
Les mainteneurs répondent en général sous 1 jour
-
JSON:API: resource schemas (`*.jsonapi`) have `properties` but no `type: object`Peut-être pris @ousamabenyounes l’a pris il y a 16 jours. Ouverte
Difficulté 2/5 Moins d'une heure Accessibilité débutants 80/100
api-platform/core#8701 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
api-platform/core#8771 ·
Les mainteneurs répondent en général sous 1 jour
-
Doctrine ORM/ODM resource metadata collection factory runs outside the metadata cache since 4.2.16 (priority -50 vs `.cached` at -10)Peut-être pris Une pull request liée à cette issue est ouverte ou déjà fusionnée. Ouverte
Difficulté 3/5 1-2 jours Accessibilité débutants 68/100
api-platform/core#8769 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de api-platform/core
Issues similaires
-
jira-created
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
Les mainteneurs répondent en général sous 2 jours
-
enhancement
Difficulté 1/5 Moins d'une heure Accessibilité débutants 78/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100
grokability/snipe-it#19996 ·
Les mainteneurs répondent en général sous 1 jour
-
enhancement
Difficulté 1/5 Moins d'une heure Accessibilité débutants 82/100
Les mainteneurs répondent en général sous 1 jour
-
Add a dark themeOuvertegood first issue laravel-appointment-reminders
Difficulté 2/5 1-3 heures Accessibilité débutants 82/100