StorPool: resize of an encrypted volume does not account for the LUKS header (live resize fails with "Cannot grow device files", guest ends up 2 MiB short)

Ouverte
  • Quelque chose ne va pas ?
#14,695 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Description

bug
problem

When a LUKS-encrypted volume on StorPool primary storage is resized, the
plugin resizes the StorPool volume to exactly the requested size. At creation
the plugin adds 2 MiB (2097152 bytes) for the LUKS header, but the resize path
does not.

Effects:

  1. Live resize fails inside QEMU. The agent runs virsh blockresize with the
    new size; QEMU needs new size + LUKS payload offset on the underlying block
    device, which is larger than the device, and returns:

    internal error: unable to execute QEMU command 'block_resize': Cannot grow device files

    The failure is not surfaced. notifyqemu() in resizevolume.sh only logs
    "failed to live resize", the script exits 0, the agent returns success and
    the resizeVolume job succeeds. The guest keeps seeing the old size.

  2. Size mismatch. CloudStack records the requested size, but once QEMU
    re-reads the device (VM stop/start, or a manual blockresize) the guest sees
    the requested size minus the LUKS header. The same shortfall applies to
    offline resize, without any error (from code reading, not tested).

  3. Rollback uses the same unadjusted size (from code reading, not tested).
    If the StorPool API call or the agent command fails, resizeVolume() calls
    StorPoolUtil.volumeUpdate(name, oldSize, true, ...), i.e. shrinkOk=true
    with the CloudStack size. For an encrypted volume that has never been
    resized the device is oldSize + 2097152, so this requests a 2 MiB shrink of
    a LUKS device.

Code references (main at cc30155defc89bce24a253df892a0494ae8bba1e):

The header allowance was introduced with StorPool encryption support in #7539.

versions

on all versions

The steps to reproduce the bug
  1. KVM zone with StorPool primary storage and a host that supports volume
    encryption. Create a custom-size disk offering with encrypt=true, tagged
    to the StorPool pool.
  2. Create a 10 GiB data volume from that offering and attach it to a running
    VM. On the host, blockdev --getsize64 on the StorPool device shows
    10739515392 (10 GiB + 2097152); the guest sees 10737418240.
  3. Resize the volume while the VM is running:
    cmk resize volume id= size=20
  4. Observe:
    • the resizeVolume job succeeds and CloudStack reports 20 GiB
    • blockdev --getsize64 shows 21474836480 (exactly 20 GiB, no allowance)
    • libvirtd logs the block_resize "Cannot grow device files" error
    • the guest still sees 10 GiB

Expected: the StorPool volume is resized to 20 GiB + 2097152, blockresize
succeeds, and the guest sees 20 GiB, matching what CloudStack reports.

What to do about it?

Apply the same allowance on resize as on create, for encrypted volumes only:

  • In updateVolumeByOffering and updateVolumeByStorPoolQoS, send
    payload.newSize + 2097152 to the StorPool API when the volume has a
    passphrase (or KMS key on main). updateVolumeByStorPoolQoS needs the
    volume passed in.
  • Use the same adjusted size for the rollback in resizeVolume().
  • Keep payload.newSize for the agent command and for the size stored in
    the database.

Sketch:

private static long getStorPoolVolumeSize(VolumeObject vol, long size) {
    boolean encrypted = vol.getPassphraseId() != null || vol.getKmsKeyId() != null;
    return encrypted ? size + 2097152 : size;
}

Volumes already resized under this bug have no allowance; the next resize
after the fix would correct them.

Separately, it may be worth surfacing the blockresize failure instead of
returning success, so a failed live resize is visible in the job result.

Langage dominant
Java
Étoiles
3.1k
Forks
1.4k
Merge moyen
7 j 16 h
PR mergées (30 j)
15

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de apache/cloudstack

Toutes les issues de apache/cloudstack

Issues similaires

Plus d'issues Java

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.