Template diagnostics not updated in watch mode on Windows when the type-check block is unchanged

Ouverte
#34,725 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

  • #34733 par @Matt-code-d — fermée sans fusion

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
angular, typescript

Piste de recherche

Start with the resource invalidation check in packages/angular/build/src/tools/angular/compilation/aot-compilation.ts and the modified file handling in packages/angular/build/src/tools/esbuild/angular/source-file-cache.ts. Trace how resource dependency paths are compared during ng serve watch rebuilds on Windows, then check the existing compilation tests for coverage of that path comparison. Done means template diagnostics refresh on Windows when a template changes without changing its type-check shim, while Linux behavior remains correct.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area: @angular/build
Command

serve

Is this a regression?
  • Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was

No response

Description

On Windows, during ng serve, a template edit that changes Angular diagnostics without changing the generated type-check code is not diagnosed: a stray </span> (NG5002) still ends with "Application bundle generation complete", and [attr.width.px] never shows NG8106. Linux and ng build report both correctly.

The resource check that invalidates diagnosticCache (aot-compilation.ts#L334) looks up forward-slash paths from getResourceDependencies() in modifiedFiles, which holds path.normalized backslash paths (source-file-cache.ts#L42), so it never matches on Windows:

modifiedFiles:        ["C:\\repro\\src\\app\\app.html"]
resourceDependencies: ["C:/repro/src/app/app.html"]
match:                false   (Linux: true)

Edits that change the .ngtypecheck.ts shim are still picked up by the TypeScript builder; the others rely on this check alone. A possible fix is hostOptions.modifiedFiles.has(path.normalize(resourceDependency)).

Minimal Reproduction

Repro: https://github.com/te-gis-dev/ng-stale-template-diagnostics (node repro.mjs runs all steps against ng serve and restores the files).

With @angular/build 22.2.7, run ng serve, then:

  1. Append </span> to src/app/app.html. Expected NG5002; actual on Windows: build completes, no error.
  2. Revert, then append <p [attr.width.px]="1"></p>. Expected NG8106 warning; actual on Windows: none.
  3. Add a blank line to src/app/app.ts. The missing diagnostics appear.
Setup Stray </span> [attr.width.px]
22.2.7, Windows 11, Node 26.12.1 not reported not reported
22.2.7, Linux (Docker node:24) correct correct
Exception or Error
Windows:
Application bundle generation complete.

Linux:
✘ [ERROR] NG5002: Unexpected closing tag "span". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags [plugin angular-compiler]
Application bundle generation failed.
Your Environment
Angular CLI       : 22.2.7
Angular           : 22.2.6
Node.js           : 26.12.1
Package Manager   : npm 11.16.0
Operating System  : win32 x64

┌───────────────────────────┬───────────────────┬───────────────────┐
│ Package                   │ Installed Version │ Requested Version │
├───────────────────────────┼───────────────────┼───────────────────┤
│ @angular/build            │ 22.2.7            │ 22.2.7            │
│ @angular/cli              │ 22.2.7            │ 22.2.7            │
│ @angular/common           │ 22.2.6            │ 22.2.6            │
│ @angular/compiler         │ 22.2.6            │ 22.2.6            │
│ @angular/compiler-cli     │ 22.2.6            │ 22.2.6            │
│ @angular/core             │ 22.2.6            │ 22.2.6            │
│ @angular/forms            │ 22.2.6            │ 22.2.6            │
│ @angular/platform-browser │ 22.2.6            │ 22.2.6            │
│ @angular/router           │ 22.2.6            │ 22.2.6            │
│ rxjs                      │ 7.8.2             │ ~7.8.0            │
│ typescript                │ 6.0.3             │ 6.0.3             │
└───────────────────────────┴───────────────────┴───────────────────┘
Anything else relevant?
  • Windows only; drive-letter casing is not involved.
  • Latent on main / 22.3.0-rc.0: #34173 marks the component affected through Angular's incremental compilation first, but the lookup is still false on Windows. The check has never matched there since #25940.
  • On 22.2.x it also locks in the stale cached error fixed by #34173: while it is served, every template edit on Windows is ignored (repro.mjs steps 1-6).
Langage dominant
TypeScript
Étoiles
27k
Forks
11.8k
Merge moyen
1 j 2 h
PR mergées (30 j)
225

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de angular/angular-cli

Toutes les issues de angular/angular-cli

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.