`ng update` reinstalls with lifecycle scripts skipped and no notice (since 22.3.0-next.5)

Ouverte
  • Quelque chose ne va pas ?
#34,688 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
72/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
angular, node.js, typescript
Domaine
cli, devtools

Piste de recherche

Start with packages/angular/cli/src/commands/update/cli.ts:568-602 and packages/angular/cli/src/package-managers/package-manager.ts:397, then trace how the final project install options reach each package manager. Reproduce with the issue's steps and check whether lifecycle scripts run after ng update; done means scripts run as expected or the command clearly reports that they were skipped and explains how to run them.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Command

update

Is this a regression?
  • Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was

22.2.6 (every stable release; also 22.3.0-next.4)

Description

Since 22.3.0-next.5, the final "Installing packages" step of ng update passes the package
manager's ignore-scripts flag (npm install --ignore-scripts; --mode=skip-build for modern yarn).
For npm, the update first deletes node_modules ("Cleaning node modules directory"), so after the
reinstall every dependency's preinstall/install/postinstall script — including the
project's own root postinstall — has been skipped. Nothing re-runs them, nothing is printed, and
there is no flag to opt out. For pnpm/yarn/bun there is no wipe, but scripts of the packages changed
by the update are skipped the same way.

Projects that rely on lifecycle scripts break in ways that are hard to connect back to the update:

  • patch-package via root postinstall: patches are silently not applied, and the migrations that
    run right after the install operate on the unpatched tree;
  • puppeteer, cypress, and similar packages whose postinstall downloads a platform binary.

This comes from a69fe511c ("default ignoreScripts to true when install options are provided"). In
all released versions the final install runs scripts normally: v21.0 still used the legacy
installAll() (no flag), and from 21.1 through 22.2 the = { ignoreScripts: true } parameter
default on install() was replaced entirely by the options object the update command passes
({ ignorePeerDependencies }), so the flag was never added. a69fe511c makes the default apply
per property, which looks right for the temporary tooling installs — but it also silently turns on
script skipping for the final, persistent install of the user's project.

If skipping scripts here is intended, could the command print a notice (e.g. "Lifecycle scripts were
skipped during installation; run your package manager's install/rebuild command to execute them")
and/or offer an opt-out? Otherwise, the final install could pass ignoreScripts: false to restore
the stable-release behavior.

Minimal Reproduction
  1. npx @angular/[email protected] new repro --defaults && cd repro
  2. Add a visible root lifecycle script to package.json:
    "postinstall": "node -e \"require('node:fs').writeFileSync('postinstall-ran.txt','yes')\""
  3. npm install → postinstall-ran.txt is created. Delete it: rm postinstall-ran.txt
  4. npm install --save-dev --save-exact @angular/[email protected]
  5. npx ng update @angular/core --next
  6. After "Cleaning node modules directory" and "Installing packages" finish, postinstall-ran.txt
    does not exist — no install script ran, with no notice. Repeating steps 4–5 with
    @angular/[email protected] in step 4 recreates the file.
Exception or Error
(none — the scripts are skipped without any notice, which is the issue)
Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI       : 22.3.0-next.5
Node.js           : 24.15.0
Package Manager   : yarn 1.22.22
Operating System  : darwin arm64
Anything else relevant?

Code on main:

  • packages/angular/cli/src/commands/update/cli.ts:568-602 — the npm-only "Cleaning node modules
    directory" task followed by packageManager.install({ ignorePeerDependencies }), with no
    ignoreScripts override;
  • packages/angular/cli/src/package-managers/package-manager.ts:397 —
    const { force, ignoreScripts = true, ignorePeerDependencies } = options; in install().

Defaulting to ignore-scripts for the temporary package acquisitions (ng add/ng update tooling
installs) is good hardening and not what this issue is about — only the final project install.
Reproduces with every package manager; npm is affected most because of the preceding node_modules
wipe. Not OS- or browser-specific.

Langage dominant
TypeScript
Étoiles
27k
Forks
11.8k
Merge moyen
1 j 3 h
PR mergées (30 j)
271

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de angular/angular-cli

Toutes les issues de angular/angular-cli

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.