Keyed reorder moves the row that moved earlier, so a focused input in it loses focus (React keeps focus)

Ouverte
#150 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
75/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript, react, typescript

Piste de recherche

Start by reading placeDomsInOrder in dist/dom/reconcile.js and the keyed reorder test setup using Vitest, jsdom, and Testing Library described in the issue. Reproduce [a, b] to [b, a] with focus on b, then inspect which DOM row the reconciliation moves. Done when the reorder preserves the focused input and the regression test passes.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Version: @tanstack/redact 0.3.0

When a keyed list is reordered, Redact moves a different DOM node than React does. If the node it moves contains the focused element, the browser blurs it (moving a focused node with insertBefore drops focus in Chromium, Firefox and WebKit), so focus ends up on <body>. React keeps focus in the same case.

Repro (Vitest + jsdom + Testing Library)
import { render, screen } from '@testing-library/react';
import { expect, test } from 'vitest';

test('a keyed reorder keeps focus in the row that moves earlier', () => {
  const list = (order) => (
    <div>{order.map((id) => <div key={id}><input aria-label={id} /></div>)}</div>
  );
  const { rerender } = render(list(['a', 'b']));
  const b = screen.getByLabelText('b');
  b.focus();
  rerender(list(['b', 'a']));
  expect(screen.getByLabelText('b')).toBe(b);   // passes on both: the node is kept
  expect(document.activeElement).toBe(b);       // React: b. Redact: body
});

React 19.2.8 passes; Redact 0.3.0 fails the focus assertion.

Where it seems to come from

For [a, b] -> [b, a], React leaves the rows whose relative order is unchanged in place and moves the ones that fall behind (it moves a). placeDomsInOrder in dist/dom/reconcile.js walks backwards and calls insertBefore on rows that move earlier (it moves b), which takes focus away from the row the user is working in. The same happens when an item is moved to the top of a list.

Matching React's placement (walk the new order forwards, track the highest current DOM index among rows left in place, and move only rows whose current index is below it) would keep focus. moveBefore could help where it exists, but jsdom and some browsers don't have it.

Real-world impact

Keyboard users lose focus when the row they're in moves up: "move up" buttons, lists that re-sort, or lists that put the newest item first while a control in a row has focus. Scroll position and media inside the moved row can also reset.

Langage dominant
TypeScript
Étoiles
581
Forks
28
Merge moyen
13 h 48 min
PR mergées (30 j)
45

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/redact

Toutes les issues de TanStack/redact

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.