Unkeyed siblings after a .map() list are remounted when the list changes length (React keeps them)

Ouverte
#149 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
react, typescript
Domaine
frontend

Piste de recherche

Start with pushChildren in dist/dom/reconcile.js and trace how reconcile() assigns keys to children from nested arrays. Run the provided Vitest and jsdom reproduction, then compare behavior for a changing list and for two lists in one parent. Done means later unkeyed siblings retain their DOM nodes and state, while each nested list has its own key scope, matching the React behavior described.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Version: @tanstack/redact 0.3.0 (also 0.2.6)

When a .map() list changes length, Redact recreates every unkeyed sibling that comes after the list in the same parent: new DOM nodes, fresh component state, lost focus and lost uncontrolled input values. React keeps them, because it treats each child array as a single slot.

It happens for [a] -> [a, b], [a, b] -> [a] and undefined -> []. Swapping null for a one-item array does not trigger it.

Repro (Vitest + jsdom + Testing Library)
import { useState } from 'react';
import { fireEvent, render, screen } from '@testing-library/react';
import { expect, test } from 'vitest';

test('an unkeyed sibling after a list keeps its DOM node when the list grows', () => {
  function Form() {
    const [items, setItems] = useState(['a']);
    return (
      <div>
        {items.map((item) => <p key={item}>{item}</p>)}
        <input aria-label="field" />
        <button onClick={() => setItems(['a', 'b'])}>add</button>
      </div>
    );
  }
  render(<Form />);
  const field = screen.getByLabelText('field');
  field.value = 'typed';
  fireEvent.click(screen.getByText('add'));
  expect(screen.getByLabelText('field')).toBe(field);        // React: same node. Redact: new node
  expect(screen.getByLabelText('field').value).toBe('typed'); // Redact: ''
});

React 19.2.8 passes; Redact 0.3.0 fails both assertions.

Where it seems to come from

pushChildren in dist/dom/reconcile.js flattens nested arrays into the parent's child list, and reconcile() then matches unkeyed children by their index in that flat list (child.key ?? i). When the array's length changes, every later unkeyed sibling shifts index and is unmounted and remounted. A side effect is that two .map() lists in one parent also share a key space, which React keeps separate.

Treating each nested array as an implicit fragment (one slot with its own key scope) would match React.

Real-world impact

We hit it in a settings form: a validation warnings list (warnings?.map(...)) went from undefined to [] on Save, and every field below it was rebuilt, so the field the user was typing in lost its value and focus.

Possibly related to the "separate Fragment identity bug" mentioned in #92.

Langage dominant
TypeScript
Étoiles
581
Forks
28
Merge moyen
13 h 48 min
PR mergées (30 j)
45

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/redact

Toutes les issues de TanStack/redact

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.