reach: a timed-out run reused after an edit depends on timeouts, so its coverage is no longer required (#90)

Ouverte
#104 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
20/100
Type d'issue
Bug
Clarté
À clarifier
Activité
Active
Stack technique
javascript
Domaine
testing

Piste de recherche

Start in the witness module's edit sequence (an edit sequence over the witness module) and find where PR #90 dropped the state a timed-out run reused after an edit. Look at its predicate daemon.evidence.cut < coldRun.evidence.cut, then at how the CLI assigns cut counts, and compare with the #84 fix for the heartbeat state. Done means the cut comes from a recorded count rather than wall-clock timeouts, so the state can be required again and the witness unit passes deterministically. Run the witness unit test to confirm.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

PR #90 removed the reach state a timed-out run reused after an edit from the witness module's edit sequence. Its predicate compares the cut counts of a daemon check and a cold run (daemon.evidence.cut < coldRun.evidence.cut), and those counts depend on wall-clock timeouts. Determinism failed on the witness unit because the state was present in one run and not the other.

The state is no longer observed, required, or entered by its constructed history (an edit sequence over the witness module). That is a coverage loss: nothing now claims that the daemon reuses a timed-out run after an edit. Law 9 is still judged on the outcomes of that history, since the comparison runs on every check.

What restores it

A deterministic cut: the witness's hang is cut by a count the CLI records (for example, a call budget or an owner's run count), not by the clock. With that, the state's predicate depends only on the history, and the state can be observed and required again. #84 is the same kind of fix for the heartbeat state.

Authority

Register (2026-11-14): "Determinism under load covers witnesses too: an oracle driver must not rely on wall-clock ordering." The evidence counts are not observed, as for cli (note in the stability check).

Langage dominant
JavaScript
Étoiles
5
Forks
1
Merge moyen
8 h 31 min
PR mergées (30 j)
60

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/oracles

Toutes les issues de TanStack/oracles

Issues similaires

Plus d'issues JavaScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.