Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Offline action reports success after leadership loss before outbox admission

Fermée
  • Quelque chose ne va pas ?
#1,939 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
50/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
typescript
Domaine
distributed-systems, documentation, testing-qa

Piste de recherche

Start with packages/offline-transactions/tests/leadership-replay.property.test.ts and run the provided Vitest probe command. Trace persistTransaction() through its leadership guard and resolveTransaction(), then compare the public transaction settlement contract with the offline admission behavior. Extend coverage for selection-to-admission leadership loss, update docs/contributing/oracle-coverage.md and the guide from #1938, and verify the no-success-without-durability case.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Bug

An offline action can report success after it loses leadership but before its mutation reaches the outbox. The mutation is neither durable nor sent to the server. In the controlled reproduction below, the Collection row is also absent after the success signal.

This was found while reviewing the documentation in #1938. The production code is unchanged by that docs PR. It is related to the offline admission policy tracked in #1659, but this is a concrete current-path failure.

Reproduction

On commit 9bf2444072c3c4aefebd072efd08f14be99afb0a, save this as packages/offline-transactions/tests/leadership-admission-review-probe.test.ts:

import { expect, it } from 'vitest'
import { createTestOfflineEnvironment } from './harness'

it('does not report success when leadership is lost before outbox admission', async () => {
  const env = createTestOfflineEnvironment()
  await env.waitForLeader()

  const action = env.executor.createOfflineAction({
    mutationFnName: env.mutationFnName,
    onMutate: (item: {
      id: string
      value: string
      completed: boolean
      updatedAt: Date
    }) => {
      env.collection.insert(item)
      env.leader.setLeader(false)
    },
  })

  try {
    const transaction = action({
      id: 'handoff-item',
      value: 'Buy milk',
      completed: false,
      updatedAt: new Date(),
    })
    const outcome = await transaction.isPersisted.promise.then(
      () => 'fulfilled',
      () => 'rejected',
    )
    const durable = await env.executor.peekOutbox()

    expect(env.executor.isOfflineEnabled).toBe(false)
    expect(env.collection.get('handoff-item')).toBeUndefined()
    expect([outcome, durable.length, env.mutationCalls.length]).not.toEqual([
      'fulfilled',
      0,
      0,
    ])
  } finally {
    env.executor.dispose()
    await env.collection.cleanup()
  }
})

Run pnpm --filter @tanstack/offline-transactions exec vitest run tests/leadership-admission-review-probe.test.ts. The test fails with:

AssertionError: expected [ 'fulfilled', +0, +0 ] to not deeply equal [ 'fulfilled', +0, +0 ]

The leadership change happens synchronously in onMutate, after createOfflineAction() has selected its offline wrapper. persistTransaction() reaches its guard after an await and calls resolveTransaction() when leadership is gone. It never calls outbox.add() or the configured mutationFn. The completion promise then fulfills.

Expected behavior and coverage

An action must not report success when no durable record exists and no server mutation ran. The admission policy needs a decision: either reject and roll back the action at this boundary, or hand it off durably to the next leader. The first option appears smaller, but both should be checked against the public transaction settlement contract.

packages/offline-transactions/tests/leadership-replay.property.test.ts is the primary leadership oracle. It covers already durable replay but does not generate the selection-to-admission leadership loss. Extend its grammar and public observations to cover that transition and nearby legal histories; prove the witness fails on current code and passes with the repair. Record the resulting scope in docs/contributing/oracle-coverage.md.

The guide in #1938 says actions use the online-only path when offline mode is disabled. That describes actions that start while it is disabled, but not this action, which selected the offline path before leadership changed. Update the guide alongside the behavior decision.

Langage dominant
TypeScript
Étoiles
4k
Forks
277
Merge moyen
1 j 2 h
PR mergées (30 j)
213

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/db

Toutes les issues de TanStack/db

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.