Rebound keys are ignored on some screens and conflicts are accepted

Ouverte
  • Quelque chose ne va pas ?
#7 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
78/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
frontend, game-dev

Piste de recherche

Start with shared/ui.ts, shared/settings.ts, shared/pause.ts and src/hub/settings-panel.ts, then trace the named onStart and Snake GameScene.ts call sites. Check how ArcadeControls and default bindings are represented before following the current menu prompts and rebinding capture flow. Run npm run typecheck and npm run build; done means rebound Action works across menus and prompts, prompts show the current key, and duplicate bindings are not silently accepted.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug severity: medium

Summary

Custom key bindings are honoured by ArcadeControls and OptionMenu but not by onStart, raw key listeners or on-screen prompts. The rebinding dialog also accepts a key that is already used by another action.

Where

  • shared/ui.ts:48-51 (keydown-SPACE / keydown-ENTER hard-coded)
  • shared/scenes.ts:68-69, shared/pause.ts:62, shared/pause.ts:124 (literal prompt strings)
  • games/snake/scenes/GameScene.ts:393-398
  • src/hub/settings-panel.ts:82-97 (capture with no clash check), src/hub/settings-panel.ts:103 (reset clears every binding)

Impact

After rebinding Action, menus built with modes need the new key while plain menus still need Space or Enter, and hints name keys that no longer work. Binding one key to two actions makes one press fire both. Fixing one mistake means resetting all bindings.

Steps to reproduce

  1. Hub Settings: change Action to K.
  2. Open Breakout: K does not start the game and the prompt still says SPACE.
  3. Open Pong: K selects a mode and Space does nothing.

Suggested fix

  • Have onStart take an ArcadeControls (or read the action binding from settings).
  • Add a keyLabel(action) helper and use it in prompts.
  • In the settings panel, detect a clash against other actions' custom and default keys and swap or warn; reject Tab and bare modifiers; add a per-row "Default" button.

Acceptance criteria

  • A rebound Action key works on every menu, start prompt and rematch screen
  • Prompts show the current binding
  • The dialog does not silently accept a duplicate key

Getting started

  • Relevant files: shared/ui.ts, shared/settings.ts, src/hub/settings-panel.ts, shared/pause.ts
  • Run locally: npm install, then npm run dev
  • Checks: npm run typecheck and npm run build (there is no test suite yet)
  • Related docs: README.md

Related: #1

Filed by repo-audit/full-audit at b001f5d. Severity: medium. Effort: M. audit-key: bug|shared/ui.ts|onStart

Langage dominant
TypeScript
Étoiles
3
Forks
3
Aucune PR mergée en 30 j

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/GH-Arcade

Toutes les issues de TMHSDigital/GH-Arcade

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.