[BUG]: Blocks on a different parent are classified INVALID and get the sender banned

Ouverte
#185 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@kansalakshat y travaille déjà.

Depuis le 15/11/2026.

  • #186 par @kansalakshat — ouverte

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
python
Domaine
blockchain

Piste de recherche

Start at minichain/chain.py:184, where _apply_block chooses between INVALID and FAILED based on whether "hash" appears in the exception text, and read the previous-hash, index and timestamp checks around it to see how each raises. Reproduce by building two Blockchain() instances from the same genesis, mining block 1 on each, and passing one chain's block to the other to confirm ValidationStatus.INVALID. Note that PR #186 already proposes a one-line change plus a test, so read it before starting rather than duplicating it; done means a parent mismatch returns FAILED and the existing reject/bann path no longer bans an honest peer.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug
Bug Description

Blockchain._apply_block picks the rejection status with INVALID if "hash" in str(exc) else FAILED (minichain/chain.py:184). The previous-hash check raises "invalid previous hash ...", which contains "hash", so a block built on a different parent is classified INVALID. With INVALID_THRESHOLD = 1 the sending peer is banned on the first such block, and the ban is persisted.

So two miners that find a block at the same height ban each other, and a node that is 2+ blocks behind bans the peer that gossips the tip (then main.py asks that same peer for a sync).

Proposed fix: only "invalid hash" and "invalid Proof of Work" stay INVALID; a parent mismatch becomes FAILED, like the index and timestamp checks. I have a one-line patch with a test.

Steps to Reproduce
  1. Create two Blockchain() instances from the same genesis.
  2. Mine block 1 on each.
  3. chain_b.add_block(block1_from_a) returns ValidationStatus.INVALID.

Same result when a fresh node receives the tip of a peer that is 2 blocks ahead.

Logs and Screenshots
[WARNING] [minichain.chain] Block 1 rejected: invalid previous hash 8325...addc != 0000...b6f1
same-height fork block from honest peer: ValidationStatus.INVALID
honest peer 2 blocks ahead, we receive its tip: ValidationStatus.INVALID
Environment Details

main @ e16ae98, Python 3.13

Impact

High - Major feature is broken

Code of Conduct
  • I have joined the Discord server and will post updates there
  • I have searched existing issues to avoid duplicates
Langage dominant
Python
Étoiles
12
Forks
27
Merge moyen
2 min
PR mergées (30 j)
1

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de StabilityNexus/MiniChain

Toutes les issues de StabilityNexus/MiniChain

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.