Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Nightly Windows test shards fail on temp-path spelling (RUNNER~1 vs canonical \\?\ paths)

Fermée
  • Quelque chose ne va pas ?
#1,689 6 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Une pull request liée a déjà été fusionnée.

  • #1710 par @mikolalysenko — fusionnée

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
github-actions, rust
Domaine
ci-cd, testing

Piste de recherche

Start by reading the failing tests named in the nightly logs: governing_root.rs:3320, get_failure_paths.rs:1660, and uv.rs:2389, then inspect the shared temp directory constructors used by those suites. Reproduce on Windows and compare the test expectations with the paths returned by the code. Done means the Windows nightly shards pass reliably with path comparisons that handle canonical prefixes, short names, and separators.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

agent:claimed agent:triaged ci-janitor priority:p3

[agent] The full-scope nightly's Windows test shards failed on 2 of the last 3 nights. A different test fails each night, and every failure we could read compares one temp path in two different spellings.

2026-10-23, run 39907645034 (aa69125)

  • test (windows-latest, 1), -p socket-patch-core --lib: hosted::governing_root::tests::vlt_project_root_governs_unlisted_directories (governing_root.rs:3320). The message names the same temp dir as C:\Users\RUNNER~1\AppData\Local\Temp\.tmpnPw8bm\tools/x (8.3 short name, mixed separators) and as \\?\C:\Users\unneradmin\AppData\Local\Temp\.tmpnPw8bm (canonical, verbatim prefix).
  • Same job, -p socket-patch-cli --test user_patches: also failed. The test name isn't recoverable from the session's log access (the log is too long to tail).
  • test (windows-latest, 2), -p socket-patch-cli --test get: get_failure_paths::engine_nested_apply_preserves_conflicts_introduced_during_fetch (get_failure_paths.rs:1660), assert!(skip["reason"]...contains(patch.to_str())). This is a substring check of a raw tempdir path against a message that probably carries the canonical one.

2026-10-22, run 39730006970 (3b6a85c)

  • test (windows-latest, 1), -p socket-patch-core --lib: patch::redirect::upstream::uv::tests::global_uv_settings_reads_the_user_then_first_system_file (uv.rs:2389). left ["…\.tmp1nilbo\xdg\uv\uv.toml"], right ["…\.tmp1nilbo\xdg/uv/uv.toml", "…\.tmp1nilbo\dirs2/uv/uv.toml"].

2026-10-21 (39551481612) was green.

Likely shared cause (needs confirming): tests build expected paths from tempfile paths (RUNNER~1 8.3 form, / joins in format strings) and compare them by string or substring with paths the code canonicalized (\\?\C:\Users\<long name>). Whether a runner's %TEMP% comes back in 8.3 form seems to vary between images and runs, so it fails intermittently. A fix in the test harness would canonicalize test tempdirs once, e.g. with a dunce::canonicalize-style helper in the tempdir constructors the suites share, and build expected paths with Path::join, not format!("{}/…").

This doesn't affect PR or merge-queue CI (lean scope has no Windows), only the nightly.

Generated by Claude Code

Langage dominant
Rust
Étoiles
8
Forks
2
Merge moyen
19 h 53 min
PR mergées (30 j)
667

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de SocketDev/socket-patch

Toutes les issues de SocketDev/socket-patch

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.