Idle CPU: a fixed 10 ms main loop, and a PulseAudio stream that stays open after the stream ends

Ouverte
  • Quelque chose ne va pas ?
#92 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
42/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
cpp, linux
Domaine
audio-video-rtc, performance

Piste de recherche

Start with the fixed sleep in the main loop: LOOP_INTERVAL_MS at src/main.cpp:57 and the sleep_for block at src/main.cpp:733-743. The PulseAudio cork/close fix belongs in the code that handles the stream-ended event, which the payload does not name, so locate it first. Run the player with -o pulse, go idle after a stream ends, and confirm with pactl that the sink input is corked and the sink suspends. Done means both idle wakeup rates drop and the sink suspends, but the loop change may need the library to expose a waitable fd first.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Summary

An idle player has a CPU floor that never drops, and a stream that has ended keeps the sound server busy too. Neither is large, but both show up in "why does an idle player use CPU at all" reports. Downstream: music-assistant/local-audio-addon#31, where an idle player used about three times what the Music Assistant server did.

Measured on v0.3.0 (sendspin-cpp v0.8.0), -o pulse into Home Assistant OS's PulseAudio, x86_64, 4 cores.

1. The main loop polls every 10 ms, idle or not

src/main.cpp:57 sets LOOP_INTERVAL_MS = 10. Every pass polls mDNS, the control socket, the network provider, the sink and the hooks, then does sleep_for(10ms) (main.cpp:733-743), whether or not anything is happening.

Thread Wakeups/s CPU
main (sendspin-cli) 98 ~0.9% of one core, idle after a stream

That is the whole idle floor of the process. A loop that blocks on its file descriptors (the control socket, the mDNS fd, the websocket) with a timeout set by the next due timer would bring an idle player close to zero wakeups. The catch is that sendspin-cpp's network provider is polled from this loop (network provider polled only from the main loop in the v0.9.5 notes), so the library would need to expose something to wait on.

2. The native PulseAudio stream is never corked or closed when a stream ends

After I player: Stream ended, with status reporting state: paused and stream: idle, the PulseAudio sink input stays connected and uncorked:

Sink Input #3
	Sink: 0
	Corked: no
		application.name = "sendspin-cli"
0	alsa_output.pci-0000_00_1f.3.analog-stereo	...	RUNNING

The result:

  • libpulse's I/O thread (threaded-ml) keeps waking about 97 times a second.
  • The server's sink stays RUNNING and never suspends. The PulseAudio daemon itself sat at 1.6% of a core, almost all in its ALSA sink thread.
  • Any USB DAC or amp behind the sink is held awake, and module-suspend-on-idle never gets the chance to act.

Corking the stream at stream end (and uncorking at the next start), or closing it, would let the sink suspend. I haven't checked whether the ALSA, PipeWire or PortAudio sinks hold their device the same way.

How it was measured

Per-thread utime+stime deltas from /proc/<pid>/task/*/stat over 10-20 s windows, and voluntary plus nonvoluntary context-switch deltas from /proc/<pid>/task/*/status for the wakeup rates. Sink state is from pactl list sink-inputs and pactl list short sinks inside the Home Assistant audio container.

Langage dominant
C++
Étoiles
18
Forks
7
Merge moyen
1 j 12 h
PR mergées (30 j)
26

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Sendspin/sendspin-cpp-cli

Toutes les issues de Sendspin/sendspin-cpp-cli

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.