SAFE on a python script blocks when the body mentions subprocess or base64

Ouverte
#252 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
42/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
python, typescript

Piste de recherche

Start by tracing hasInterpreterCodeRisk, the decision order branches 5 and 6, and the SAFE post-filter; the issue identifies these as the relevant paths but gives no file names. Compare both proposed policy changes and run the adversarial and gitflow corpora, as the issue requires a measured evaluation. Done means the selected behavior lets a reviewer allow this file-body flag while critical-pattern, lookalike, and moderate-risk-token flags remain hard blocks.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

A SAFE verdict on python3 <script>.py still blocks whenever the script body contains subprocess, base64, or a \x.. escape anywhere. In the last two days that refused 4 commands Jev had already cleared, in 4 different repos. None of them has a path to the reviewer.

Command What tripped hasInterpreterCodeRisk
python -I scripts/preflight.py <hex> \x00, \x14 (byte literals in a hash test)
python3 scripts/site-structure.py validate base64 x2
python3 scripts/testflight.py import subprocess, subprocess. x5
python3 -I ops/memory/test_sync.py import subprocess, subprocess. x1
python3 x.py ─► script body read ─► INTERPRETER_CODE_RISK matches ─► flag "python3 runs x.py"
                                                                         │
Jev: SAFE ─► decision order branch 6 (overlaid SAFE, never reviewed) ─► "flagged" block

Root cause: #67 put the inline -c markers on script bodies read from disk. For a one-line -c, subprocess or b64decode is a strong signal that the real work is hidden somewhere else. In a 300-line test script or release tool it's ordinary code, and the classifier has already read every line of it. The marker can't tell a subprocess.run(["git", "status"]) the judge saw from a decoded payload it didn't.

Two ways to fix it, each with a cost:

  1. Narrow the markers for file bodies to actual second execution: exec(, eval(, compile( in code mode, __import__, marshal, and a b64decode whose result reaches one of those. Keeps the hard block. Costs a regex that has to track data flow, which is what got #67's markers this broad in the first place.
  2. Send this one flag class (interpreter risk in a file body) to branch 5 instead of branch 6, so the stage 2 reviewer sees the body and the user's words. The gate's SAFE post-filter then has to accept a reviewer allow for this flag only. Critical-pattern, lookalike and moderate-risk-token flags stay hard.

I lean toward 2. It's a policy change to the overlay, so it needs a measured run over the adversarial and gitflow corpora before it ships.

Langage dominant
TypeScript
Étoiles
1
Forks
1
Merge moyen
49 min
PR mergées (30 j)
82

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de STRML/omp-classifier

Toutes les issues de STRML/omp-classifier

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.