Efuse logical-map override: end-user loadable patch file (RAM-only)

Ouverte
#284 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
35/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Calme
Stack technique
c, json
Domaine
embedded-iot

Piste de recherche

Start with the four materialization sites named in the issue: src/jaguar1/EepromManager.cpp, src/jaguar2/HalJaguar2.cpp, and both variant paths in src/jaguar3/HalJaguar3.cpp; also inspect examples/common/env_config.cpp and the existing replay_wseq handling. Begin by establishing machine-readable logical-map dumps and headless tests, then cover sparse patch parsing, each generation’s apply point, and the 8814A late re-read. Done means tests cover ID behavior and reapplication, and diagnostics make overrides visible; the issue also calls for hardware validation.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement

Motivation

The efuse logical map is the root of almost every per-adapter parameter we consume: MAC, xtal cap, thermal baseline, RFE type, PA/LNA types, per-channel TX-power PG base. Today it is read-only and invisible except for the stderr DEVOURER_EFUSE_DUMP text (Jaguar2/3 only). A RAM-only override lets us:

  • test "what would this adapter do with rfe_type=N / xtal=M" without touching hardware state,
  • resurrect adapters with corrupted efuse (force the autoload-OK ID, supply a sane map),
  • act as the validation harness for physical efuse programming (see follow-up issue): dump → edit → run with override → validate on-air → only then burn.

Shape

A sparse patch file applied after logical-map materialization, before field parsing.

  • DeviceConfig::Debug::efuse_override (path, std::optional<std::string>), env-mapped as DEVOURER_EFUSE_OVERRIDE in examples/common/env_config.cpp — same pattern as replay_wseq, which is the existing precedent for a library-loaded file path.
  • Grammar: 0xCA=0x04 single bytes, 0x22:8=xxxxxxxxxxxxxxxx runs. A full-map binary replace can be a second, explicitly named mode later — it must not be the default (a full dump from adapter X replayed on adapter Y silently clobbers Y's calibration).
  • The patch parser and the apply helper are generation-neutral pure functions → live in src/ next to PhyTableLoader, unit-testable headlessly (ctest).

Implementation details / hazards

  1. Four materialization sites, not one. Jaguar1 decodes into efuse_eeprom_data (src/jaguar1/EepromManager.cpp:1382), Jaguar2 into _efuse_map (src/jaguar2/HalJaguar2.cpp:305), Jaguar3 has two variant paths — 8822C standard walk and 8822E packed 2-byte headers into a one-shot cache (src/jaguar3/HalJaguar3.cpp:621-719). One shared apply_efuse_override(map, len) called at each site.
  2. 8814A re-reads efuse after FW download (LateInitFor8814A, src/jaguar1/EepromManager.cpp:89). The override must re-apply on that second read or the 8814 silently loses the patch. Needs a dedicated test.
  3. 8822E PA bias bypasses the logical map — it reads physical addresses 0x5c5–0x5c8 during the power-cut bracket (src/jaguar3/HalJaguar3.cpp:580). A logical override cannot affect it. v1: document the hole; a phys: patch plane doubles the surface and is not worth it yet.
  4. Autoload/ID semantics cut both ways. Jaguar1 gates on ID 0x8129 at offset 0x00 (Hal_EfuseParseIDCode8812A). A wrong override flips the device into autoload-fail defaults; forcing it right is how you resurrect a corrupt-efuse adapter. Both directions need tests.
  5. Dump tooling is a prerequisite. You cannot author an override without a dump in the same grammar. Extend DEVOURER_EFUSE_DUMP to emit a machine-readable logical map on all three generations (JSONL efuse.map event or file) — today it is stderr text and Jaguar2/3 only; Jaguar1 only has the physical ReadPhysicalEfuseMap health probe.
  6. Footgun visibility. One-shot W diagnostic diffing every overridden byte + an efuse.override JSONL event, so test scripts can assert the patch took effect and nobody benchmarks on doctored calibration without noticing.

Suggested milestones

  1. Machine-readable logical-map dump, all generations (efuse.map event).
  2. Sparse-patch parser + apply_efuse_override in src/, headless selftests.
  3. Wire into the four materialization sites (incl. the 8814A late re-read) + efuse.override event.
  4. Hardware validation: override rfe_type / xtal on a bench adapter, confirm the parsed-field logs and on-air behavior follow.
Langage dominant
C
Étoiles
56
Forks
29
Merge moyen
3 h 43 min
PR mergées (30 j)
75

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de OpenIPC/devourer

Toutes les issues de OpenIPC/devourer

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.