Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Android: per-runtime statics are read and written from runtime threads without a lock

Ouverte
  • Quelque chose ne va pas ?
#99 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
45/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
android, cpp
Domaine
backend, mobile

Piste de recherche

Start by reading the listed Android N-API and JSI files, then compare their shared static maps and APP_ROOT_FOLDER_PATH assignments with the tns::ConcurrentMap usage mentioned in the issue and the Hermes env_to_jsr_mutex guard. Check how the quickjs and primjs backends store env_to_jsr_cache as well. Done means concurrent runtime creation and disposal cannot corrupt state another runtime reads; the issue names no tests to run.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Summary

Several process-wide statics hold one entry per runtime, or one value set by every runtime. Each runtime reads and writes them from its own thread, with no lock. When workers start or stop while other runtimes are running, these are data races of the same kind as #93: a hash table can rehash under a concurrent reader, and a std::string can be reallocated under a concurrent reader.

Static Where Written Read
JSR::env_to_jsr_cache (std::unordered_map) NativeScript/napi/v8/jsr.cpp js_create_napi_env, js_free_napi_env js_lock_env / js_unlock_env
MetadataNode::s_arrayObjects (robin_hood::unordered_map) NativeScript/ffi/jni/{napi,jsi}/metadata/MetadataNode.cpp first array-constructor lookup in each runtime; erased on dispose every array-constructor lookup
envToPersistentSmartJSONStringify / rtToPersistentSmartJSONStringify (robin_hood::unordered_map) NativeScript/ffi/jni/{napi,jsi}/global/GlobalHelpers.cpp first JsonStringifyObject in each runtime; erased on dispose every JsonStringifyObject
Constants::APP_ROOT_FOLDER_PATH (std::string) NativeScript/ffi/jni/{napi,jsi}/constants/Constants.cpp assigned in Runtime::Init of every runtime (NativeScript/runtime/android/{napi,jsi}/Runtime.cpp) module resolution, stack traces, MetadataNode origins, inspector

The quickjs and primjs backends keep env_to_jsr_cache in a tns::SimpleMap, which has no lock either. The hermes backend already guards its copy with env_to_jsr_mutex.

MetadataNode::s_metadata_node_cache and (with #96) ArgConverter's long-conversion cache already use tns::ConcurrentMap, which is the pattern to follow for the maps.

Expected

Creating or disposing one runtime can't corrupt state another runtime is reading. Possible fixes:

  • the per-runtime maps move to tns::ConcurrentMap with the Get / Insert / Remove pattern used in #96, or become per-runtime state;
  • APP_ROOT_FOLDER_PATH is set once per process, since every runtime computes the same value (filesRoot + "/app/"), or is guarded.

Environment

  • Branch: android-react-native at 64c7fed0
  • Found by reading the code while fixing #93; these were not seen crashing on their own.

Related: #93, #96, and #97 and #98 (the console timer maps).

Langage dominant
C++
Étoiles
27
Forks
4
Merge moyen
16 h 48 min
PR mergées (30 j)
4

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de NativeScript/runtimes

Toutes les issues de NativeScript/runtimes

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.