Deprecate the profilerOutputDir profiler and name Java members in V8/DevTools profiles
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Accessibilité débutants
- 35/100
- Type d'issue
- Fonctionnalité
- Clarté
- Plutôt claire
- Activité
- Active
- Stack technique
- android, cpp
- Domaine
- mobile, performance
Piste de recherche
Start by reading Profiler.cpp, MetadataNode::Wrap, and the core and CLI declarations for profilerOutputDir; the issue also points to @nativescript/core/profiling and the follow-up to #2099. Compare DevTools profiles for the listed Java constructors, methods, fields, and functions created by extend or interface implementations, then review V8's naming APIs. Done means the legacy profiler's deprecation or removal path is resolved and Java members have useful profile names; the issue leaves API compatibility decisions open.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Is your feature request related to a problem? Please describe.
The runtime ships a legacy profiler, added in 2016 (d81045c76), next to the Chrome DevTools profiler:
Profiler.cppalways installs three globals:__startCPUProfiler(name)and__stopCPUProfiler(name)wrap V8'sCpuProfiler, and stopping writes<profilerOutputDir>/<app>-<name>-<time>.cpuprofile.__heapSnapshot()writes a.heapsnapshotfile to the same directory.
- Setting
android.profilerOutputDiralso turns onMetadataNode::Wrap. That compiles a named JS wrapper around every Java class constructor and every Java method (function getAlpha() { return getAlpha.__func.apply(this, arguments); }) so that profiles show Java member names. The wrappers add a JS frame to every call and replace the functions apps see. In that mode a wrapper'sprototype.constructoris the inner function, not the class the app sees.
As far as I can tell nobody uses it:
- nothing in core, the CLI, the plugins or angular sets
profilerOutputDir; - with the default empty value,
Writebuilds a path at/and fails, so the globals produce nothing unless the option is set.
The only consumers I found are @nativescript/core/profiling's startCPUProfile/stopCPUProfile, which call these globals on Android, and the profilerOutputDir entries in core's config.interface.ts and the CLI's project.d.ts.
The DevTools CPU and heap profilers cover the same ground through the inspector, with a better workflow. The one thing the legacy profiler does that they don't is to start and stop from app code with no inspector attached.
Describe the solution you'd like
-
Deprecate the legacy profiler.
- Log a deprecation warning when
profilerOutputDiris set. - Remove
MetadataNode::Wrapands_profilerEnabledin the next major release. - Decide what happens to
__startCPUProfiler/__stopCPUProfiler/__heapSnapshot, and to core'sstartCPUProfile/stopCPUProfile:- remove them along with the profiler;
- or keep them as thin helpers that write to the app's files directory by default, for profiling a release build without an inspector.
- Deprecate
profilerOutputDirin core's config types and the CLI's typings at the same time.
- Log a deprecation warning when
-
Make V8/DevTools profiles more informative instead. Java members should show up under useful names in a DevTools CPU profile without wrapper functions. Start by checking what a profile shows today for:
- Java class constructors (
FunctionTemplate::SetClassNameis already set to the dotted Java name); - instance and static methods (prototype template functions);
- field accessors and static members;
- functions created by
extendand interface implementations.
Then fill the gaps with V8's naming APIs:
FunctionTemplate::SetClassName,Function::SetName, or naming the template functions after their property keys. Where a name alone is ambiguous across overloads or same-named methods of different classes, include the declaring class, e.g.android.view.View.getAlpha.- Optionally, label the time spent in the JS↔Java bridge: callback dispatch from Java, argument conversion and
ObjectManagerwrapper creation. A DevTools profile could then tell bridge overhead apart from app JS. V8's CPU profiler supports embedder states and trace events that could carry this.
- Java class constructors (
Describe alternatives you've considered
- Keep the profiler as is. It costs little at runtime when off:
Wrapreturns the function unchanged unlessprofilerOutputDiris set. But it is unmaintained, undocumented, and has semantic quirks when on. - Keep only the wrapper naming. It changes the functions apps see and adds a frame per call, so it distorts the very profiles it is meant to label.
Additional context
This came up while optimizing JS wrapper creation for Java objects, in the follow-up to #2099. Dropping a wrapper's own constructor property only made a difference in this profiler mode, where wrapper.constructor now resolves to the inner, unwrapped constructor, as new-created instances already did.
- Langage dominant
- C++
- Étoiles
- 565
- Forks
- 147
- Merge moyen
- 1 j 2 h
- PR mergées (30 j)
- 27
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de NativeScript/android
-
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
NativeScript/android#2107 ·
Les mainteneurs répondent en général sous 1 jour
-
ErrorReportActivity draws under the status bar on targetSdk 35 (forced edge-to-edge)Peut-être pris @aleclarson l’a pris il y a 48 jours. Ouverte
Difficulté 3/5 1-2 jours Accessibilité débutants 76/100
NativeScript/android#2053 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 38/100
NativeScript/android#2039 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 4/5 3-5 jours Accessibilité débutants 48/100
NativeScript/android#2024 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 5/5 Plus d'une semaine Accessibilité débutants 20/100
NativeScript/android#2020 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de NativeScript/android
Issues similaires
-
Difficulté 1/5 1-3 heures Accessibilité débutants 77/100
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
phantoslayer21/wronggpu#275 ·
Les mainteneurs répondent en général sous 1 jour
-
bug good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
ReyeMe/SaturnRingLib#155 ·
-
bug
Difficulté 2/5 1-3 heures Accessibilité débutants 62/100
Nheko-Reborn/nheko#2092 ·
-
Difficulté 1/5 1-3 heures Accessibilité débutants 78/100
isocpp/CppCoreGuidelines#2345 ·