New colors don't match old v4.x colors

Ouverte
  • Quelque chose ne va pas ?
#3,590 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
25/100
Type d'issue
Bug
Clarté
À clarifier
Activité
À l'abandon
Stack technique
csharp
Domaine
design, desktop

Piste de recherche

Commencez par MaterialDesignTheme.ObsoleteBrushes.xaml et le point d’entrée ThemeAssist.GetResourceDictionarySource présenté dans l’issue. Comparez les mappages obsolètes et les ressources des thèmes clair et sombre aux attentes de surface v4.x et MD3 signalées. La tâche serait terminée lorsqu’un schéma de couleurs de surface aura été convenu et qu’une approche pour les dictionnaires de ressources de thèmes personnalisés aura été décidée.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug evaluation required
Bug explanation

When using MaterialDesignTheme.ObsoleteBrushes.xaml to substitute the new colors to the old ones, the swap isn't good enough. For instance, some of the colors:

LgSprYsEft

It can clearly be seen that, in dark mode, the old background being substituted by the card background is not at all the same. I used it as the lowest layer of the app, but now it doesn't work anymore for that. In light mode instead, the situation wasn't great before either with way too much similarity between the colors, and now it's even worse, with the colors having been reduced to just two shades.

This all scheme also doesn't really match MD3 guidelines, since it doesn't really go from the lowest surface to the highest surface, like this:

firefox_mnPbr4Rec6
firefox_MVdXHc9DUt

Up until now I've personally used the surfaces as lowest to highest like this: Background->Toolbar->Paper->Card

  1. We could keep doing this by fixing the colors so that they follow more MD3 guidelines, maybe with a couple more surfaces.
  2. Alternatively, new colors could be added to represent the various surfaces (ie MaterialDesign.Brush.Surface.Lowest etc...)
  3. Alternatively, again, the ElevationAssist.Elevation could be used in some way to change the colors, but I wouldn't know how.

In my opinion, the first one would be easier to do and less disruptive to everyone's work. I've tried throwing together as a proposal:

immagine

Other things that could be added would be more Neutral colors, so every x50 step from 0 to 1000 in order to have more granularity. I'm not sure how the colors were chosen, though.

Also a simple way to substitute the default themes with custom ones (ie create my one resource dictionary and pass it to the ThemeAssist when calling ChangeTheme(). Right now I can only find this hard-coded reference to the themes:

private static string? GetResourceDictionarySource(BaseTheme theme)
{
    return theme switch
    {
        BaseTheme.Light => "pack://application:,,,/MaterialDesignThemes.Wpf;component/Themes/MaterialDesignTheme.Light.xaml",
        BaseTheme.Dark => "pack://application:,,,/MaterialDesignThemes.Wpf;component/Themes/MaterialDesignTheme.Dark.xaml",
        _ => null,
    };
}

I'm not sure what would be the best way to pass a new dictionary to the ThemeAssist, or if it's even the best place to do such thing.

What do you think?

Version

5.0.0

Langage dominant
C#
Étoiles
16.3k
Forks
3.5k
Merge moyen
4 h 25 min
PR mergées (30 j)
4

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de MaterialDesignInXAML/MaterialDesignInXamlToolkit

Toutes les issues de MaterialDesignInXAML/MaterialDesignInXamlToolkit

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.