tools/phase2_plants.sh has four of the seven plants #1758 names: plants 5, 6 and 7 are missing

Ouverte
#2,463 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
44/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
c, shell
Domaine
testing, tooling

Piste de recherche

Start with tools/phase2_plants.sh, tools/phase2_check.sh, tests/phase2/MAP.md, and the tool's row in tools/selftests.txt. Read how existing plants create scratch copies and clean controls, then run the phase 2 plant tool to inspect its output and counts. Done when plants 5–7 are killed by their named MAP checks, plant 4 is killed by A.add-overflow-raises, the self-test pins match the output, and weakening a named check lets a plant survive and makes the tool fail.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:gates kind:gate-defect

tools/phase2_plants.sh is the tool behind the "Planted faults" box of #1758, which names seven plants. The tool runs sixteen plants and kills them all, but three of the seven that the box names are not among them, and were never added.

On phase2-numbers at f9f3e49b:

$ git show f9f3e49b:tools/phase2_plants.sh | grep -c -i 'INT64_MIN\|neg-min\|num_type\|v6'
0
$ git grep -n "Plant [567]'s named check" f9f3e49b -- tests/phase2/MAP.md
tests/phase2/MAP.md:346:  tag: a double, no raise. **Plant 5's named check.**
tests/phase2/MAP.md:436:  tag: `num_type` undefined. **Plant 6's named check.**
tests/phase2/MAP.md:656:  tag: rc 0 (the fixture is its own version). **Plant 7's named check.**
plant of #1758 in the tool the row tests/phase2/MAP.md names as its check
1. an int that fits inline stored boxed run_plant 1 the slot test
2. a NaN stored raw in a slot run_plant 2 N12.nan-payload-tags and the slot test
3. a writer accepting a non-finite value run_plant 3-json, run_plant 3-store
4. + wrapping instead of raising on overflow run_plant overflow-wrap, whose check is the slot test's overflow_add arm A.add-overflow-raises
5. -INT64_MIN wrapping missing N4b.neg-min-raises
6. num_type of 3.0 returning "int" missing N7.num-type-float
7. a v6 tape accepted missing T1.v6-refused

The three rows exist and pass in every tier (they are change rows of tools/phase2_check.sh: red on the tag, green on the branch). What is missing is the other direction: nothing has shown that each of them turns red when the fault it is named for is put into the runtime. A reading of #1758's boxes on 2026-11-19 said the tool "holds the box's seven"; that sentence was not run and is corrected there.

Done when

  • The tool has plants 5, 6 and 7, each made the way its other plants are made (run_plant, one edit in a scratch copy, a clean control): unary minus of INT64_MIN made to wrap; num_type made to answer "int" for 3.0; the tape's version check made to accept format 6. Each is killed by the row MAP.md names for it (N4b.neg-min-raises, N7.num-type-float, T1.v6-refused), by that row's own line.
  • Plant 4 is killed by A.add-overflow-raises as well as by the slot test, or MAP.md's sentence names the check the plant has.
  • EXPECTED_PLANTS and the pins of the tool's row in tools/selftests.txt carry the new counts, taken from the tool's output; the hosted gates' self-test job passes on the head.
  • The new plants are shown to be able to survive: with the named row's check weakened in the scratch copy (one plant is enough), the tool reports survived=1 and fails.

Refs #1758.

— Claude DevBox

Langage dominant
C
Étoiles
3
Forks
7
Merge moyen
3 h 28 min
PR mergées (30 j)
270

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de InauguralSystems/EigenScript

Toutes les issues de InauguralSystems/EigenScript

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.