Stall contract: 74 of 204 single-edit mutants of the stall rule are seen by no case (integer magnitudes, the amplitude clause, the quiet threshold from above)

Ouverte
#2,434 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
46/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
c

Piste de recherche

Read src/vm.c and tests/phase2/stall_contract.py, then inspect the sweep logs from run 44452715831 to understand the 74 unseen mutants and how the existing cases exercise the stall rule. Add integer observations and a case just over the quiet threshold, and classify each mutant as detected or equivalent with its reason recorded beside it. Add the sweep tool under tools/ with a self-test row.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:gates area:observer kind:gate-defect

What. The sweep made for #2427 (222 single-edit mutants of the stall rule in src/vm.c: the reader's four functions and the loop's stall counter) left 74 mutants that no case of tests/phase2/stall_contract.py turns red: not on the base (c96498d9), not at #2427's head (b9881574). They are not #2427's doing, since the base does not see them either. Run: 44452715831; its artifacts hold every log.

Where they are.

where unseen
obs_stall_magnitude_cmp 26
obs_stall_amplitude_noncontracting 22
obs_stall_quiet 10
obs_stall_window_nonfinite 7
the loop's stall counter 1
by hand 8

Read by group, before any is run again:

  • obs_stall_magnitude_cmp (26). Every case of the contract observes doubles, so the function's integer branches and its mixed int and double branches are never taken. The mutants there are unseen because the code is unreached, not because they are equivalent.
  • The quiet threshold loosened (4 of the 8 by hand: 1.0006, 1.002, 1.01 and 1.1 times its value). The contract brackets the threshold from below (since #2427, within 0.004%). Nothing brackets it from above: a case whose steps sit just over the threshold and must NOT stall is missing. At 2 times and above, overflow-contracting and damped see it.
  • Likely equivalent, to be shown and not assumed: a return 1 made return 2 (the caller tests for nonzero), the window's extent one too long and its cap removed (the ring holds W+1), and the threshold at 0.99999 of its value (inside the bracket).
  • The rest (the amplitude clause, the reader's first lines): not read yet.

Done when

  • Each of the 74 is either turned red by a case of the contract, or shown equivalent with its reason written beside it (a program cannot tell the two builds apart, and why).
  • The contract has at least one case that observes integers (a small int, and one outside the small-int range) through the amplitude clause, and one case with steps just over the quiet threshold that must not stall.
  • The sweep's tool is in the tree (under tools/), with a self-test row, so that the next change to the stall rule or to its contract can run it.
The 74 (id, where, the edit)
c-extent+1 | by hand | `c-extent+1`
c-nocap | by hand | `c-nocap`
g-q-not-div | by hand | `if (observer_slot_quiet(s) && !observer_slot_diverging(s)) return 1;`
t-x0.99999 | by hand | `if (observer_slot_quiet(s) && fabs(s->v_rel[s->v_window_head ? s->v_window_head - 1 : s->v_cap - 1]) < g_obs_dh_zero * 0.99999) return 1;`
t-x1.0006 | by hand | `if (observer_slot_quiet(s) || (s->v_rel && s->v_window_count && fabs(s->v_rel[s->v_window_head ? s->v_window_head - 1 : s->v_cap - 1]) < g_obs_dh_zero * 1.0006)) return 1;`
t-x1.002 | by hand | `if (observer_slot_quiet(s) || (s->v_rel && s->v_window_count && fabs(s->v_rel[s->v_window_head ? s->v_window_head - 1 : s->v_cap - 1]) < g_obs_dh_zero * 1.002)) return 1;`
t-x1.01 | by hand | `if (observer_slot_quiet(s) || (s->v_rel && s->v_window_count && fabs(s->v_rel[s->v_window_head ? s->v_window_head - 1 : s->v_cap - 1]) < g_obs_dh_zero * 1.01)) return 1;`
t-x1.1 | by hand | `if (observer_slot_quiet(s) || (s->v_rel && s->v_window_count && fabs(s->v_rel[s->v_window_head ? s->v_window_head - 1 : s->v_cap - 1]) < g_obs_dh_zero * 1.1)) return 1;`
CON-L88-6d48f1 | obs_stall_magnitude_cmp | `if (a.is_int) { if (a.integer > 0) a.integer = -a.integer; }` => `if (a.is_int) { if (a.integer > 1) a.integer = -a.integer; }`
NEG-L88-a2c8ed | obs_stall_magnitude_cmp | `if (a.is_int) { if (a.integer > 0) a.integer = -a.integer; }` => `if (!(a.is_int)) { if (a.integer > 0) a.integer = -a.integer; }`
ROR-L88-074a4b | obs_stall_magnitude_cmp | `if (a.is_int) { if (a.integer > 0) a.integer = -a.integer; }` => `if (a.is_int) { if (a.integer <= 0) a.integer = -a.integer; }`
ROR-L88-49d358 | obs_stall_magnitude_cmp | `if (a.is_int) { if (a.integer > 0) a.integer = -a.integer; }` => `if (a.is_int) { if (a.integer >= 0) a.integer = -a.integer; }`
UNM-L88-104caa | obs_stall_magnitude_cmp | `if (a.is_int) { if (a.integer > 0) a.integer = -a.integer; }` => `if (a.is_int) { if (a.integer > 0) a.integer = a.integer; }`
DEL-L89-ad11a4 | obs_stall_magnitude_cmp | `else a.value = -fabs(a.value);` => `else ;`
CON-L90-ea3fba | obs_stall_magnitude_cmp | `if (b.is_int) { if (b.integer > 0) b.integer = -b.integer; }` => `if (b.is_int) { if (b.integer > 1) b.integer = -b.integer; }`
NEG-L90-c05a66 | obs_stall_magnitude_cmp | `if (b.is_int) { if (b.integer > 0) b.integer = -b.integer; }` => `if (!(b.is_int)) { if (b.integer > 0) b.integer = -b.integer; }`
ROR-L90-60c3eb | obs_stall_magnitude_cmp | `if (b.is_int) { if (b.integer > 0) b.integer = -b.integer; }` => `if (b.is_int) { if (b.integer <= 0) b.integer = -b.integer; }`
UNM-L90-3f0f12 | obs_stall_magnitude_cmp | `if (b.is_int) { if (b.integer > 0) b.integer = -b.integer; }` => `if (b.is_int) { if (b.integer > 0) b.integer = b.integer; }`
DEL-L91-ad11a4 | obs_stall_magnitude_cmp | `else b.value = -fabs(b.value);` => `else ;`
AOR-L93-36d8ee | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return (a.integer < b.integer) + (a.integer > b.integer);`
DEL-L93-c24c9a | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `;`
RET-L93-3006ae | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return 0;`
RET-L93-65ceaa | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return 1;`
ROR-L93-065593 | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return (a.integer < b.integer) - (a.integer <= b.integer);`
ROR-L93-847e2f | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return (a.integer <= b.integer) - (a.integer > b.integer);`
ROR-L93-d34785 | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return (a.integer >= b.integer) - (a.integer > b.integer);`
ROR-L93-da7773 | obs_stall_magnitude_cmp | `return (a.integer < b.integer) - (a.integer > b.integer);` => `return (a.integer < b.integer) - (a.integer >= b.integer);`
DEL-L94-734194 | obs_stall_magnitude_cmp | `if (a.is_int) return -eigs_cmp_int_float(a.integer, b.value);` => `;`
RET-L94-621707 | obs_stall_magnitude_cmp | `if (a.is_int) return -eigs_cmp_int_float(a.integer, b.value);` => `if (a.is_int) return 0;`
RET-L94-a3af6a | obs_stall_magnitude_cmp | `if (a.is_int) return -eigs_cmp_int_float(a.integer, b.value);` => `if (a.is_int) return 1;`
UNM-L94-031c44 | obs_stall_magnitude_cmp | `if (a.is_int) return -eigs_cmp_int_float(a.integer, b.value);` => `if (a.is_int) return eigs_cmp_int_float(a.integer, b.value);`
DEL-L95-734194 | obs_stall_magnitude_cmp | `if (b.is_int) return eigs_cmp_int_float(b.integer, a.value);` => `;`
RET-L95-d4ff78 | obs_stall_magnitude_cmp | `if (b.is_int) return eigs_cmp_int_float(b.integer, a.value);` => `if (b.is_int) return 1;`
ROR-L96-173b36 | obs_stall_magnitude_cmp | `return (a.value < b.value) - (a.value > b.value);` => `return (a.value <= b.value) - (a.value > b.value);`
AOR-L105-63fd99 | obs_stall_amplitude_noncontracting | `size_t full = (size_t)observer_slot_window(s) + 1;` => `size_t full = (size_t)observer_slot_window(s) - 1;`
CON-L105-c1d70b | obs_stall_amplitude_noncontracting | `size_t full = (size_t)observer_slot_window(s) + 1;` => `size_t full = (size_t)observer_slot_window(s) + 0;`
CON-L105-d1a4c1 | obs_stall_amplitude_noncontracting | `size_t full = (size_t)observer_slot_window(s) + 1;` => `size_t full = (size_t)observer_slot_window(s) + 2;`
DEL-L106-734194 | obs_stall_amplitude_noncontracting | `if (n > full) n = full;` => `;`
NEG-L106-93ff33 | obs_stall_amplitude_noncontracting | `if (n > full) n = full;` => `if (!(n > full)) n = full;`
ROR-L106-12b193 | obs_stall_amplitude_noncontracting | `if (n > full) n = full;` => `if (n <= full) n = full;`
CON-L107-5275b2 | obs_stall_amplitude_noncontracting | `if (n < 2 || !s->v_values) return 0;` => `if (n < 2 || !s->v_values) return 1;`
CON-L107-58c4a0 | obs_stall_amplitude_noncontracting | `if (n < 2 || !s->v_values) return 0;` => `if (n < 1 || !s->v_values) return 0;`
CON-L107-7217bc | obs_stall_amplitude_noncontracting | `if (n < 2 || !s->v_values) return 0;` => `if (n < 3 || !s->v_values) return 0;`
DEL-L107-734194 | obs_stall_amplitude_noncontracting | `if (n < 2 || !s->v_values) return 0;` => `;`
LOR-L107-b95707 | obs_stall_amplitude_noncontracting | `if (n < 2 || !s->v_values) return 0;` => `if (n < 2 && !s->v_values) return 0;`
ROR-L107-37a36e | obs_stall_amplitude_noncontracting | `if (n < 2 || !s->v_values) return 0;` => `if (n <= 2 || !s->v_values) return 0;`
CON-L108-42b19c | obs_stall_amplitude_noncontracting | `size_t half = n / 2;` => `size_t half = n / 3;`
CON-L109-d6fa58 | obs_stall_amplitude_noncontracting | `ObserverNumber recent = { .is_int = 1, .integer = 0 };` => `ObserverNumber recent = { .is_int = 2, .integer = 0 };`
CON-L109-e937b4 | obs_stall_amplitude_noncontracting | `ObserverNumber recent = { .is_int = 1, .integer = 0 };` => `ObserverNumber recent = { .is_int = 0, .integer = 0 };`
CON-L111-657d42 | obs_stall_amplitude_noncontracting | `for (size_t i = 0; i < n; i++) {` => `for (size_t i = 1; i < n; i++) {`
ROR-L111-d6073c | obs_stall_amplitude_noncontracting | `for (size_t i = 0; i < n; i++) {` => `for (size_t i = 0; i <= n; i++) {`
CON-L115-a11de6 | obs_stall_amplitude_noncontracting | `if (!v.is_int && !isfinite(v.value)) return 0;` => `if (!v.is_int && !isfinite(v.value)) return 1;`
DEL-L115-c24c9a | obs_stall_amplitude_noncontracting | `if (!v.is_int && !isfinite(v.value)) return 0;` => `;`
NOT-L115-67346b | obs_stall_amplitude_noncontracting | `if (!v.is_int && !isfinite(v.value)) return 0;` => `if (v.is_int && !isfinite(v.value)) return 0;`
ROR-L116-e5e35f | obs_stall_amplitude_noncontracting | `ObserverNumber *peak = i < half ? &recent : &older;` => `ObserverNumber *peak = i <= half ? &recent : &older;`
ROR-L117-b00150 | obs_stall_amplitude_noncontracting | `if (obs_stall_magnitude_cmp(v, *peak) > 0) *peak = v;` => `if (obs_stall_magnitude_cmp(v, *peak) >= 0) *peak = v;`
CON-L127-d1a4c1 | obs_stall_window_nonfinite | `size_t full = (size_t)observer_slot_window(s) + 1;` => `size_t full = (size_t)observer_slot_window(s) + 2;`
DEL-L128-734194 | obs_stall_window_nonfinite | `if (n > full) n = full;` => `;`
NEG-L128-93ff33 | obs_stall_window_nonfinite | `if (n > full) n = full;` => `if (!(n > full)) n = full;`
ROR-L128-12b193 | obs_stall_window_nonfinite | `if (n > full) n = full;` => `if (n <= full) n = full;`
CON-L129-707617 | obs_stall_window_nonfinite | `if (!s->v_values) return 0;` => `if (!s->v_values) return 1;`
DEL-L129-734194 | obs_stall_window_nonfinite | `if (!s->v_values) return 0;` => `;`
ROR-L130-d6073c | obs_stall_window_nonfinite | `for (size_t i = 0; i < n; i++) {` => `for (size_t i = 0; i <= n; i++) {`
CON-L143-23fba4 | obs_stall_quiet | `if (!s || !s->used) return 0;` => `if (!s || !s->used) return 1;`
DEL-L143-734194 | obs_stall_quiet | `if (!s || !s->used) return 0;` => `;`
LOR-L143-27f7de | obs_stall_quiet | `if (!s || !s->used) return 0;` => `if (!s && !s->used) return 0;`
DEL-L144-734194 | obs_stall_quiet | `if (!s->v_last || !s->v_used) return observer_slot_quiet(s);` => `;`
LOR-L144-db9f28 | obs_stall_quiet | `if (!s->v_last || !s->v_used) return observer_slot_quiet(s);` => `if (!s->v_last && !s->v_used) return observer_slot_quiet(s);`
RET-L144-1a661d | obs_stall_quiet | `if (!s->v_last || !s->v_used) return observer_slot_quiet(s);` => `if (!s->v_last || !s->v_used) return 0;`
RET-L144-d272a8 | obs_stall_quiet | `if (!s->v_last || !s->v_used) return observer_slot_quiet(s);` => `if (!s->v_last || !s->v_used) return 1;`
CON-L145-482029 | obs_stall_quiet | `if (obs_stall_window_nonfinite(s)) return 1;` => `if (obs_stall_window_nonfinite(s)) return 2;`
CON-L146-fa1d78 | obs_stall_quiet | `if (observer_slot_quiet(s)) return 1;` => `if (observer_slot_quiet(s)) return 2;`
CON-L147-29f7e9 | obs_stall_quiet | `if (observer_slot_diverging(s)) return 1;` => `if (observer_slot_diverging(s)) return 2;`
DEL-L2338-b04e98 | the loop counter | `g_loop_stall_count = 0;` => `;`

— Claude DevBox

Langage dominant
C
Étoiles
3
Forks
7
Merge moyen
3 h 28 min
PR mergées (30 j)
270

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de InauguralSystems/EigenScript

Toutes les issues de InauguralSystems/EigenScript

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.