Issue hygiene: #1682 duplicates half of #1646, and #2212 plus #2198's open boxes are already in #1688

Ouverte
  • Quelque chose ne va pas ?
#2,222 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
52/100
Type d'issue
Documentation
Clarté
Clairement spécifiée
Activité
Active
Stack technique
c
Domaine
tooling

Piste de recherche

Start by reading the linked issues #1646, #1682, #1688, #2198, and #2212, especially their Done-when boxes and comments. Compare the audit claims with the referenced locations in lib/ui_w_data.eigs, src/eigenscript.h, src/tape_read.c, src/state.c, and src/vm.h; then record which items are confirmed or refuted here. Done when the duplicate ownership and remaining task_sched_trace references are resolved in the tracker.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:gfx area:observer found-by:duet-audit kind:tracking

Read-only audit of the open tracker (audit area 3, issue hygiene) at main e9e5cd60. Two groups of open issues track the same defect under different numbers, so whoever fixes one may not close the other. Nothing was closed or edited by the audit.

1. #1682 is #1646's second defect
  • #1646 (2026-10-06), section "Second defect: selection contrast": lib/ui_w_data.eigs fills a highlighted ASCII cell with the highlight colour, then draws the character in hex_ascii/text_dim, which is close to it, so "the selected text ("EigenScript hex_view" in the screenshot) is unreadable". Its Done-when box 2: selected ASCII cells draw text in a contrasting colour, with a test.
  • #1682 (2026-10-08): selecting "EigenScript hex_view" in examples/ui_hex.eigs shows "a solid highlight bar with no characters". Done-when: selected ASCII characters stay readable; a draw-list or pixel assertion covers a selected ASCII cell.

Same example, same selection, same fix. Still present on main: lib/ui_w_data.eigs:676 fills the cell with the highlight colour hc, and :688 draws the glyph with ascol, with no selected-text colour.

2. #2212 and #2198 (boxes 2 and 3) are inside #1688
  • #1688 asks to delete the machinery left unreachable by #1677: obs_cfg_sync, the O cfg / O win emitters and readers, trace_obs_window_binding, observer_slot_set_window, and the task.c scheduler-trace helpers, with replay refusing old tapes. Its 2026-10-21 and 2026-10-24 comments list the stale source comments, including src/eigenscript.h "set via set_observer_thresholds" and src/tape_read.c:173-174 naming builtin_set_observer_scale/builtin_set_observer_thresholds.
  • #2212 (2026-10-30) asks to fix exactly those two comments (src/eigenscript.h:2461 and src/tape_read.c:173-174 on main).
  • #2198's open boxes 2 and 3 ask for a decision on whether replay refuses an O win record and removes trace_obs_window_binding / win_override. #1688's Done-when already chooses: delete the readers and refuse old-format tapes.
  • #1688 was waiting for "the tape-bump release". Its 2026-10-24 comment notes the bump to format 7 shipped without the removal; main is now at format 8 (src/trace.h:32), and every function it names is still defined (src/trace.c:1572 obs_cfg_sync, src/trace.c:1602 trace_obs_window_binding, src/eigenscript.c:1269 observer_slot_set_window, src/task.c:307/324/473).

Not in any of the three: src/state.c:310 ("task_sched_trace of 1 arms it from a program") and src/vm.h:691 ("builtins.c task_sched_trace") still describe the removed builtin as live. Both are listed in #1688's 2026-10-24 comment.

Expected vs actual
  • Expected: one open issue per defect, so the fix's Closes line retires all of it.
  • Actual: two numbers for the hex-view contrast bug, and three for the observer-config removal, with #2198 asking a question #1688 already answers.

Done when

  • #1682 is closed as a duplicate of #1646 (or #1646's box 2 is moved to #1682 and #1646 says so), so exactly one open issue owns the selected-ASCII contrast fix.
  • #2212 and #2198's boxes 2 and 3 are folded into #1688 (closed as duplicates with a pointer, or #1688 links them as sub-issues), and #1688's Done-when no longer says "in the tape-bump release" now that formats 7 and 8 have shipped.
  • Whichever issue owns the comments lists src/state.c:310 and src/vm.h:691, and its grep box covers task_sched_trace.
  • Each item above is marked confirmed or refuted in a comment here.

— Duet (orchestrator)

Langage dominant
C
Étoiles
3
Forks
7
Merge moyen
6 h 32 min
PR mergées (30 j)
285

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de InauguralSystems/EigenScript

Toutes les issues de InauguralSystems/EigenScript

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.