Dashboards: a stored per-dashboard default for the release-marker and alert-annotation toggles

Ouverte
#3,279 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
react, typescript

Piste de recherche

Start with DBDashboardPage.tsx and trace the dashboard model and v2 external API entry points mentioned in the issue. Define how optional releaseMarkers and alertAnnotations values are stored and exposed, preserving URL-parameter precedence and current behavior when fields are absent; done means the UI and API support per-dashboard defaults consistently.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

external

What are you trying to do?

We keep our HyperDX dashboards as files in a repository and apply them through the dashboards API, and a few of them exist to answer "did this deploy change things?". For those, release markers are the point of the dashboard, so we want them showing whenever someone opens it. The release-marker toggle (#2894) and the alert-annotation toggle live only in the URL (releaseMarkers=true, alertAnnotations=true), and DBDashboardPage.tsx describes them as "Ephemeral view state (URL param), not persisted on the dashboard". Someone who opens the dashboard from the sidebar, a search or a bookmark without the parameter doesn't see markers until they turn them on.

What would you like to see?

An optional per-dashboard default for each toggle, stored with the dashboard and settable through the API, such as releaseMarkers: true and alertAnnotations: true on the dashboard document. The URL parameter would still win, so ?releaseMarkers=false turns the markers off for one view and nothing else changes. The stored value only replaces the hard-coded false default. Dashboards without the field behave as now.

Alternatives you've considered

We add ?releaseMarkers=true to every link we publish. That covers the links we control and misses every other way of opening the dashboard. We also considered asking for markers to default to on wherever a source has a service version expression, but that changes every dashboard's behaviour and its query load, which a per-dashboard opt-in avoids.

Anything else?

The change is in the dashboard schema, UI and API: a field in the dashboard model and the v2 external API, and the toggle's default in DBDashboardPage.tsx. A "save as default" control beside the toggle could follow. If keeping the toggles out of the dashboard document was a deliberate choice, we'd like to hear why, and we're happy to take a different approach. We'd also gladly write the change if you want it.

Posted by Claude Code on behalf of Jun Matsushita.

Langage dominant
TypeScript
Étoiles
10.1k
Forks
527
Merge moyen
1 j 20 h
PR mergées (30 j)
186

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de ClickHouse/ClickStack

Toutes les issues de ClickHouse/ClickStack

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.