Hello, I am jorik

Ouverte
#3,242 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
25/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
À l'abandon
Stack technique
helm, kubernetes, mongodb, typescript

Piste de recherche

Start with the file-based dashboard provisioner and PR #3233, then read createOrUpdateDashboardAlerts and validateAlertInput, which the issue identifies as the existing alert paths. Done means provisioned tile alerts are created or updated, invalid alerts are skipped with a warning while retaining the last valid version, removed tile alerts are deleted, and app-created alerts remain unaffected.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

external

Tell us a bit about yourself before your first pull request. A couple of sentences is plenty.

Who are you?

Jorik (@jorik), a full-stack .NET developer. We run ClickStack on AKS through its Helm chart and keep our HyperDX dashboards in git with the file-based dashboard provisioner from #1962, which I really like.

What would you like to work on?

The same for alerts. The provisioner accepts a tile's config.alert (it passes DashboardWithoutIdSchema), but it writes tiles straight to Mongo and never creates the alert, so a provisioned alert validates and never fires.

https://github.com/hyperdxio/hyperdx/pull/3233 makes the provisioner create and update tile alerts through the existing createOrUpdateDashboardAlerts, after checking each one with validateAlertInput like the alerts API does. Alerts it creates are flagged provisioned: true and deleted once their tile no longer declares one. An invalid alert is skipped with a warning and keeps its last valid version, and alerts created in the app are left alone.

Anything we can help with?

A /vouch @jorik so #3233 can be reviewed, and a steer on whether provisioned alerts should replace an app-created alert on the same tile (what the PR does now) or leave it.

Langage dominant
TypeScript
Étoiles
10.1k
Forks
527
Merge moyen
1 j 20 h
PR mergées (30 j)
186

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de ClickHouse/ClickStack

Toutes les issues de ClickHouse/ClickStack

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.