Camera-only SDK recordings cannot be saved after their source ends
Les mainteneurs répondent en général sous 1 jour
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 1-2 jours
- Accessibilité débutants
- 35/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- À l'abandon
- Stack technique
- react, typescript
Piste de recherche
Read packages/sdk-recorder/src/index.ts around CapRecorder.stop() and the camera/display track handling; compare the React hook Stop path in packages/sdk-recorder/src/react/useCapRecorder.ts. Reproduce with camera mode and the microphone disabled, then verify Stop completes after the source ends during recording or pause and uploads the buffered chunks. An open linked pull request (#2971) is already addressing this issue.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Description
@cap/sdk-recorder cannot save a camera-only recording after its camera source ends while the microphone is disabled. The native MediaRecorder has already emitted the final video and stopped, but the SDK still reports recording or paused. Calling the SDK's Stop switches it to stopping forever. No upload begins, and destroying the recorder discards the buffered take.
CapRecorder.stop() installs its native stop listener only when called, then invokes native stop() unconditionally. An already-inactive MediaRecorder does nothing and emits no second stop event, so the new promise has no path to settle.
Expected: Stop saves the already-buffered recording and completes.
Reproduction
Use the class API or the exported React hook with:
const recorder = new CapRecorder({
publicKey,
mode: "camera",
microphone: { enabled: false },
});
await recorder.start();
- Record camera video, then end the camera source, for example by disconnecting an external webcam or revoking its permission.
- After native recording has ended, invoke
await recorder.stop(). - Observe the SDK remain in
stopping, with no upload requests or completed result. The paused case is also affected.
The source-ending transition was reproduced deterministically in Chromium by returning a real canvas.captureStream(30) from the camera-acquisition boundary, recording moving frames, ending its sole video track, waiting for native completion, then invoking public Stop. The SDK, MediaRecorder, media events, chunks and multipart client were real; camera acquisition and HTTP responses were local fixtures. A physical webcam disconnect was not exercised.
| Same short video fixture | Main | Proposed fix |
|---|---|---|
| Source ends during recording | 9,343 buffered bytes; Stop pending after 800 ms; zero HTTP calls | Stop resolves; all 9,343 bytes uploaded; phase complete |
| Source ends while paused | Same pending Stop and zero HTTP calls | Stop resolves and uploads the buffered video |
| Normal manual Stop | Completes | Completes |
The final patch was also replayed with Stop running while native final events were still pending. All six output files decode successfully as 320×180 VP9 video with 21 or 51 frames, and each upload matches all native chunks byte for byte. A 1.7 s replay preserves all 25,672 bytes, including its final 11,107-byte chunk. The baseline's otherwise-stranded artifacts were recovered from buffered chunks by the diagnostic fixture; there is no consumer-facing recovery feature.
Additional Context
- Baseline main:
1965b31796db6da107a8f859ff34397468ae9512. - Linux x86-64, Bun 1.4.1, Chromium 152.0.7977.167. The 800 ms timeout records the observed hang; the missed stop event explains why waiting longer cannot complete it.
- The focused fix observes native stop completion from recording startup, then awaits it before uploading. This handles both an event that already fired and final data/stop events that are still pending after native state becomes inactive.
- This is specific to the recording SDK. The Chrome extension uses a different recorder.
- Real authenticated upload, hardware-specific disconnect behavior, Firefox and Safari were not exercised. The already-reported paused-duration calculation and unrelated SDK typing issue #2915/#2917 are separate.
Relevant sources: Stop implementation, camera/display track handling, React hook Stop. The MediaRecorder stop algorithm specifies the inactive no-op.
- Langage dominant
- Rust
- Étoiles
- 23.4k
- Forks
- 2.1k
- Merge moyen
- 1 j 20 h
- PR mergées (30 j)
- 348
Préparer son environnement
- Fournit un Dockerfile ou un fichier Docker Compose
- Aucun modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de CapSoftware/Cap
-
Web player intercepts ⌘⇧M and blocks Chrome profile-menu shortcutPeut-être pris @AatmanAJ l’a pris il y a 8 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 80/100
CapSoftware/Cap#2596 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
CapSoftware/Cap#2384 · 2 commentaires ·
Les mainteneurs répondent en général sous 1 jour
-
Dashboard pagination causes full page reloads on self-hosted CapPeut-être pris @Dewin l’a pris il y a 36 jours. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 88/100
CapSoftware/Cap#2305 · 2 commentaires ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
CapSoftware/Cap#1714 · 3 commentaires ·
Les mainteneurs répondent en général sous 1 jour
-
Numeric captions disappear from transcripts and embed subtitlesPeut-être pris @AksharP5 l’a pris il y a 1 jour. Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 35/100
CapSoftware/Cap#2968 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de CapSoftware/Cap
Issues similaires
-
checkpoint/verify/rebuild_indexes on a thread holding a WriteTransaction deadlock instead of INT-001Ouvertebug known-issue
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
project-minigraf/minigraf#734 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 1/5 Moins d'une heure Accessibilité débutants 88/100
Les mainteneurs répondent en général sous 4 jours
-
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
Les mainteneurs répondent en général sous 1 jour
-
bug CLI documentation
Difficulté 2/5 1-3 heures Accessibilité débutants 67/100
openai/codex#56630 · 3 commentaires · 3 réactions ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 64/100
DayuanJiang/PecoFence#139 ·
Les mainteneurs répondent en général sous 1 jour