Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

answer_commit drops requested elements that appear only in `basis`, and loses trailing zeros in numeric cells

Ouverte
  • Quelque chose ne va pas ?
#1,481 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
38/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
sql, typescript
Domaine
tooling

Piste de recherche

Start in packages/opencode/src/altimate/tools/answer-commit.ts on the feat/analyst-v10-commit branch, where the numeric 15-significant-digit check (about line 31), the rows union schema (about lines 56-61), and the optional precision field (about lines 37-46) live, and where answer_only rendering skips basis. The three defects need separate changes: scale-preserving number rendering, rejection that names missing targets or falls back to basis, and rounding instead of rejecting long floats. Done when the three acceptance unit tests in the issue pass, but the maintainers still need to decide how compound requests are detected.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

Two independent defects in answer_commit (packages/opencode/src/altimate/tools/answer-commit.ts, present on the analyst-commit branches, not yet on main) cause a correct computation to be reported as an incomplete or differently formatted final answer.

  1. Compound requests lose elements. With answer_only: true the basis is never rendered; only fields / rows reach the final output. When a question asks for two things ("the repository and the most frequently copied file"), models commit one field and place the second item only in basis. The second item is silently dropped.
  2. Trailing zeros are lost. Cell values are z.union([z.string(), number, z.null()]) and rendered with String(value). A JSON number 5.00 reaches the tool as JS 5 and renders as 5, next to sibling cells such as 4.18. precision is opt-in, so nothing restores the scale.
  3. Valid numbers are rejected. Numbers with more than 15 significant digits (for example a float32 artefact 18.440000534057617 printed by sql_execute) are rejected until the model re-sends them as strings.

Mechanism

  • Numeric validation: the 15-significant-digit check at about answer-commit.ts:31; rows schema union at about :56-61; precision optional at :37-46 (line numbers from branch feat/analyst-v10-commit).
  • answer_only rendering skips basis, so a requested element that exists only there never reaches the output.

Evidence

Recorded analyst sessions:

  • Compound request: 5 of 5 sessions that used answer_commit committed only the repository field and returned an 18-byte answer, while the same model without the tool answered with both items in all 5 sessions. 4 of the 5 committed the same repository as the correct answers.
  • Trailing zero: in 5 sessions on a question whose answer has averages like 4.18 and 5.00, 3 sessions passed the number 5 and returned an incorrect answer; the 2 that passed the string "5.00" were correct. The source SQL had printed 5.000000 and 5.0.
  • 9 further calls were rejected for passing 15+ significant digit doubles or float32 artefacts.

Impact

Answer-losing: about 8 incorrect answers in the recorded sessions that were otherwise computed correctly. No time or cost effect.

Proposed fix

  • Before rendering with answer_only, compare the number of requested outputs (parse "X and Y", "for each ...") with the committed fields; on mismatch reject with the list of missing targets, or fall back to rendering the basis.
  • Render each numeric column with the maximum decimal scale present in that column (or the source result's scale).
  • Accept numbers with more than 15 significant digits and round to precision instead of rejecting.

Acceptance check

  • Unit test: rows with cells 5 and 4.18 renders 5.00 and 4.18 when the column scale is 2.
  • Unit test: a two-target question committed with one field is rejected naming the missing target (or renders the basis).
  • Unit test: a float32 artefact value is accepted and rounded.

Applies to the answer_commit tool introduced in #1449.

Langage dominant
TypeScript
Étoiles
812
Forks
123
Merge moyen
1 j 11 h
PR mergées (30 j)
97

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de AltimateAI/altimate-code

Toutes les issues de AltimateAI/altimate-code

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.