Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Determinant and Inverse return wrong values when called from more than one thread

Ouverte
  • Quelque chose ne va pas ?
#40 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

@Rafael-SOWNet y travaille déjà.

Depuis le 9/9/2026.

  • #41 par @Rafael-SOWNet — ouverte

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
À l'abandon
Stack technique
csharp
Domaine
performance

Piste de recherche

Commencez par SquareMatrixFactory<T, TWrapper>.GetMatrix et ExpressionCompiler<T, TWrapper>.storage, puis reproduisez les échecs de déterminant/inversion signalés avec Parallel.For, y compris avec un cache froid. Le travail est terminé lorsque les opérations matricielles concurrentes renvoient les valeurs vérifiées séquentiellement, sans exceptions de collection ni corruption des tampons partagés.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Two process-wide statics are read and written with no synchronisation, so matrix operations called from more than one thread return wrong numbers. Nothing throws, nothing is malformed, and no result looks suspicious.

I found this from the other side: AngouriMath uses GenTensor for its symbolic matrices, and a determinant computed on a background thread was coming back numerically wrong. AngouriMath's issue is #1219.

1. The scratch-matrix pool

SquareMatrixFactory<T, TWrapper>.GetMatrix hands every caller the same GenTensor for a given size, and the caller then writes into it — Inversion.GetCofactorMatrix(t, temp, ...) fills the matrix it is given. Two threads taking a determinant or an inverse of the same size get the same buffer and overwrite each other's minors between the write and the read.

Sixty 5×5 int matrices, each computed once sequentially for truth and then rebuilt and recomputed under Parallel.For:

DeterminantLaplace    53 of 60 disagree
Adjoint               60 of 60 disagree

Around 10 ms, every run. This is not a rare interleaving, it is the normal case.

DeterminantGaussianSafeDivision is unaffected — it works on its own copy and never asks the pool for anything.

The lock inside GetMatrix does not help and is itself incomplete: the list is indexed after the lock is released, so a concurrent Add can reallocate the backing array underneath the reader.

2. The compiled-operation cache

ExpressionCompiler<T, TWrapper>.storage is a plain Dictionary, written by whichever thread first asks for a given (operation, rank, parallel). Dictionary<,> is documented as safe for concurrent readers only while nobody is writing.

Reached cold from several threads it fails with the runtime's own diagnostic:

System.InvalidOperationException: Operations that change non-concurrent collections must
have exclusive access. A concurrent update was performed on this collection and corrupted
its state. The collection's state is no longer correct.
...
The given key '(Subtraction, 1, False)' was not present in the dictionary.

Worth noting that this one hides easily. My first test computed its expected values sequentially and only then went parallel, which populated every key before the threads started — the cache holds a handful of entries, so a warm-up makes the defect invisible and the test passes against the broken code.

Fix

I have opened a PR. Both are small: [ThreadStatic] for the pool, since a scratch buffer has nothing to share between threads, and ConcurrentDictionary for the cache. The Laplace determinant comes out about 5% faster, because the pool is now taken once at the top of the recursion instead of re-checked and re-indexed at every one of its n! nodes.

Langage dominant
C#
Étoiles
52
Forks
6
Aucune PR mergée en 30 j

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de ASC-Community/GenericTensor

Toutes les issues de ASC-Community/GenericTensor

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.