[BUG] Signature component fires change event with `modified = false` on user input

Open
#647 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
react, typescript
Domain
frontend

Research direction

Start with the linked sandbox and trace the signature component's user-input path into the onChange handler. Confirm the change event reports modified=true after drawing, while preserving the expected behavior for non-user changes.

Written by the indexing model from the issue text.

Description

Describe the bug
modified flag in onChange handler is supposed to indicate whether the change was made by a user, however in the case of signature component it always fires with false

To Reproduce
Steps to reproduce the behavior:

  1. Go to sandbox
  2. Open console
  3. Draw on signature component
  4. Console logs false for modified even though it was changed due to user input

Expected behavior
modified to be true when signature component was changed by user input

Sandbox Example
Sandbox example

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
Dominant language
TypeScript
Stars
371
Forks
309
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from formio/react

All issues in formio/react

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.