Using `Set` more

Open
#403 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
haskell
Domain
performance

Research direction

Start with src/Modelling/ActivityDiagram/MatchPetri.hs around lines 272-303, as linked in the issue, and inspect which list computations can use sets. Determine the broader scope by searching for similar computations in the repository; done means the applicable computations use sets without changing behavior.

Written by the indexing model from the issue text.

Description

copilot-eventually refactor

Various computations happen on lists that could (and algorithmically should) be done with sets.

For example here: https://github.com/jvoigtlaender/modelling-tasks-internal/blob/59bb0793b5f236e5088bc6facc2d931c110fadb4/src/Modelling/ActivityDiagram/MatchPetri.hs#L272-L303

Dominant language
Haskell
Stars
0
Forks
3
Avg merge
19h 37m
Merged PRs (30d)
5

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fmidue/modelling-tasks

All issues in fmidue/modelling-tasks

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.