Resolve usage of `convertToSimple` and `convertToPetriNet`

Open
#397 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
haskell
Domain
tooling

Research direction

Start by locating all usages and definitions of convertToSimple, convertToPetriNet, fromPetriLike, and TypeApplication. Compare the type requirements described in the issue and choose one consistent conversion approach. Done means the selected API usage is applied consistently and the affected code still type-checks.

Written by the indexing model from the issue text.

Description

ad

convertToPetriNet should be used when flexibility over the type is required. convertToSimple enforces type PetriLike SimpleNode PetriKey. convertToPetriNet is required when fromPetriLike is used on the result (which currently requires PetriLike Node a) or no specific type needs to be chosen. It would be possible to use TypeApplication together with convertToPetriNet and retire convertToSimple completely. Another view would be to use convertToSimple whenever possible.

Originally posted by @marcellussiegburg in https://github.com/jvoigtlaender/modelling-tasks-internal/issues/395#issuecomment-3302690590

Dominant language
Haskell
Stars
0
Forks
3
Avg merge
19h 37m
Merged PRs (30d)
5

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fmidue/modelling-tasks

All issues in fmidue/modelling-tasks

Similar issues

More Haskell issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.